FIX: bad_by_manual failing in ransac ch pos (#173)

sappelhoff · web-flow · commit 244123d9db12 · 2025-11-07T19:28:24.000Z
diff --git a/pyprep/find_noisy_channels.py b/pyprep/find_noisy_channels.py
@@ -661,7 +661,9 @@ def find_bad_by_ransac(
             self.EEGFiltered,
             self.sample_rate,
             self.ch_names_new,
-            self.raw_mne._get_channel_positions()[self.usable_idx, :],
+            self.raw_mne._get_channel_positions(self.raw_mne.ch_names)[
+                self.usable_idx, :
+            ],
             exclude_from_ransac,
             n_samples,
             sample_prop,
diff --git a/tests/test_find_noisy_channels.py b/tests/test_find_noisy_channels.py
@@ -237,6 +237,7 @@ def test_find_bad_by_ransac(raw_tmp):
     }
     bads = {}
     corr = {}
+    raw_tmp.info["bads"] = ["Pz"]
     for name, args in test_matrix.items():
         nd = NoisyChannels(
             raw_tmp, do_detrend=False, random_state=ransac_rng, matlab_strict=args[0]

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ def test_find_bad_by_ransac(raw_tmp):`
`237`	`237`	`}`
`238`	`238`	`bads = {}`
`239`	`239`	`corr = {}`
	`240`	`+ raw_tmp.info["bads"] = ["Pz"]`
`240`	`241`	`for name, args in test_matrix.items():`
`241`	`242`	`nd = NoisyChannels(`
`242`	`243`	`raw_tmp, do_detrend=False, random_state=ransac_rng, matlab_strict=args[0]`