Fix staticheck warnings, update dependencies

Author: kayrus

Makefile

@@ -3,7 +3,7 @@ APP_NAME:=nova-password
 PWD:=$(shell pwd)
 UID:=$(shell id -u)
 VERSION:=$(shell git describe --tags --always --dirty="-dev")
-LDFLAGS:=-X main.Version=$(VERSION)
+LDFLAGS:=-X main.Version=$(VERSION) -w -s
 
 export CGO_ENABLED:=0
 
@@ -13,6 +13,7 @@ build: fmt vet
 	GOOS=windows go build -mod=vendor -ldflags="$(LDFLAGS)" -o bin/$(APP_NAME).exe $(PKG)
 
 docker:
+	docker pull golang:latest
 	docker run -ti --rm -e GOCACHE=/tmp -v $(PWD):/$(APP_NAME) -u $(UID):$(UID) --workdir /$(APP_NAME) golang:latest make
 
 fmt:

go.mod

@@ -1,14 +1,14 @@
 module github.com/sapcc/nova-password
 
-go 1.14
+go 1.15
 
 require (
 	github.com/google/uuid v1.1.2
-	github.com/gophercloud/gophercloud v0.13.0
-	github.com/gophercloud/utils v0.0.0-20200918191848-da0e919a012a
+	github.com/gophercloud/gophercloud v0.15.1-0.20210205220151-18b16b34db5c
+	github.com/gophercloud/utils v0.0.0-20210209042946-13abf2251886
 	github.com/howeyc/gopass v0.0.0-20190910152052-7cb4b85ec19c
-	github.com/kayrus/putty v1.0.1
+	github.com/kayrus/putty v1.0.2
 	github.com/spf13/cobra v1.0.0
 	github.com/spf13/viper v1.7.1
-	golang.org/x/crypto v0.0.0-20201002094018-c90954cbb977
+	golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad
 )

go.sum

@@ -53,7 +53,7 @@ var RootCmd = &cobra.Command{
 		// Convert Unix path type to Windows path type, when necessary
 		keyPath := filepath.FromSlash(viper.GetString("private-key-path"))
 
-		if quiet == false {
+		if !quiet {
 			log.Printf("private-key-path: %s\n", keyPath)
 		}
 
@@ -126,8 +126,8 @@ var RootCmd = &cobra.Command{
 			for _, server := range args {
 				err = processServer(client, server, v, wait, quiet)
 				if err != nil {
-					log.Printf("Error getting the password for the %q server: %s", server, err)
-					errors = append(errors, fmt.Errorf("Error getting the password for the %q server: %s", server, err))
+					log.Printf("error getting the password for the %q server: %s", server, err)
+					errors = append(errors, fmt.Errorf("error getting the password for the %q server: %s", server, err))
 				}
 			}
 		default:
@@ -234,14 +234,14 @@ func processServer(client *gophercloud.ServiceClient, server string, privateKey
 		if err != nil {
 			return err
 		}
-		if quiet == false {
+		if !quiet {
 			log.Printf("Resolved %q server name to the %q uuid", tmp, server)
 		}
 	}
 
 	var res servers.GetPasswordResult
 	if wait > 0 {
-		if quiet == false {
+		if !quiet {
 			log.Printf("Waiting for %d seconds to get the password", wait)
 		}
 		// Wait for the encrypted server password
@@ -264,7 +264,7 @@ func processServer(client *gophercloud.ServiceClient, server string, privateKey
 		return err
 	}
 
-	if quiet == false {
+	if !quiet {
 		fmt.Printf("%q instance password: %s\n", tmp, pwd)
 	} else {
 		fmt.Printf("%s\n", pwd)
@@ -312,7 +312,7 @@ func readKey(path string) ([]byte, error) {
 
 	size := stat.Size()
 	if size > MaxKeySize {
-		return nil, fmt.Errorf("Invalid key size: %d bytes", size)
+		return nil, fmt.Errorf("invalid key size: %d bytes", size)
 	}
 
 	if size == 0 {
@@ -335,8 +335,8 @@ func getKeyPass(quiet bool) ([]byte, error) {
 	pass := env.Getenv("NOVA_PASSWORD_KEY_PASSWORD")
 
 	if pass == "" {
-		if quiet == true {
-			return nil, fmt.Errorf(`Private key is encrypted with the password, please set the "NOVA_PASSWORD_KEY_PASSWORD" environment variable`)
+		if quiet {
+			return nil, fmt.Errorf(`private key is encrypted with the password, please set the "NOVA_PASSWORD_KEY_PASSWORD" environment variable`)
 		}
 
 		log.Print("Private key is encrypted with the password")