Update settings to use GUID keys and add migration logic

Migrated all settings to use GUID keys via SettingKeyAttribute.
Added automatic migration on app launch for both local and
confidential settings. Improves uniqueness and future extensibility
of settings management.

Author: rykoma

Graph-Editor/App.xaml.cs

@@ -45,6 +45,9 @@ public App()
         /// <param name="args">Details about the launch request and process.</param>
         protected override void OnLaunched(Microsoft.UI.Xaml.LaunchActivatedEventArgs args)
         {
+            // Migrate all settings to GUID keys (runs once)
+            GraphEditorApplication.MigrateAllSettingsToGuidKeys();
+
             // Load request and response logging disabled setting
             if (GraphEditorApplication.GetSetting(GraphEditorApplication.Settings.GlobalSetting_DisableRequestAndResponseLoggingWhenAppRestart, true) && GraphEditorApplication.GetSetting(GraphEditorApplication.Settings.GlobalSetting_RequestAndResponseLoggingEnabled, false))
             {

Graph-Editor/GraphEditorApplication.cs

@@ -9,15 +9,28 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
+using System.Reflection;
 using System.Text;
 using System.Threading.Tasks;
 using Windows.Security.Credentials;
 using Windows.Storage;
 
 namespace Graph_Editor
 {
+    [AttributeUsage(AttributeTargets.Field)]
+    public class SettingKeyAttribute : Attribute
+    {
+        public string Key { get; }
+
+        public SettingKeyAttribute(string key)
+        {
+            Key = key;
+        }
+    }
+
     public static class GraphEditorApplication
     {
+        private const string MigrationCompletedFlagKey = "_SettingsMigrationToGuid_Completed";
         public readonly static int DefaultMaxExecutionRecordCount = 30;
 
         public static void NavigateToMainEditor()
@@ -88,18 +101,136 @@ public static string RemoveProblematicCharacters(string Input)
             return temp;
         }
 
+        private static string GetSettingKey(Settings setting)
+        {
+            var fieldInfo = setting.GetType().GetField(setting.ToString());
+            var attribute = fieldInfo?.GetCustomAttribute<SettingKeyAttribute>();
+
+            return attribute?.Key ?? setting.ToString();
+        }
+
+        public static void MigrateAllSettingsToGuidKeys()
+        {
+            var localSettings = ApplicationData.Current.LocalSettings;
+
+            if (localSettings.Values.ContainsKey(MigrationCompletedFlagKey))
+            {
+                return;
+            }
+
+            Debug.WriteLine("Starting settings migration to GUID keys...");
+
+            MigrateLocalSettings();
+            MigrateConfidentialSettings();
+
+            localSettings.Values[MigrationCompletedFlagKey] = true;
+            Debug.WriteLine("Settings migration completed.");
+        }
+
+        private static void MigrateLocalSettings()
+        {
+            var localSettings = ApplicationData.Current.LocalSettings;
+
+            foreach (Settings setting in Enum.GetValues<Settings>())
+            {
+                try
+                {
+                    string oldKey = setting.ToString();
+
+                    if (oldKey.Contains("Password"))
+                    {
+                        continue;
+                    }
+
+                    string newKey = GetSettingKey(setting);
+
+                    if (oldKey == newKey || localSettings.Values.ContainsKey(newKey))
+                    {
+                        continue;
+                    }
+
+                    if (localSettings.Values.ContainsKey(oldKey))
+                    {
+                        var value = localSettings.Values[oldKey];
+                        localSettings.Values[newKey] = value;
+                        Debug.WriteLine($"Migrated setting: {oldKey} -> {newKey}");
+                    }
+                }
+                catch (Exception ex)
+                {
+                    Debug.WriteLine($"Failed to migrate setting {setting}: {ex.Message}");
+                }
+            }
+        }
+
+        private static void MigrateConfidentialSettings()
+        {
+            var vault = new PasswordVault();
+
+            foreach (Settings setting in Enum.GetValues<Settings>())
+            {
+                if (!setting.ToString().Contains("Password"))
+                {
+                    continue;
+                }
+
+                try
+                {
+                    string oldKey = setting.ToString();
+                    string newKey = GetSettingKey(setting);
+
+                    if (oldKey == newKey)
+                    {
+                        continue;
+                    }
+
+                    try
+                    {
+                        var existingNew = vault.Retrieve("Graph-Editor", newKey);
+                        if (existingNew != null)
+                        {
+                            continue;
+                        }
+                    }
+                    catch
+                    {
+                    }
+
+                    try
+                    {
+                        var oldCredential = vault.Retrieve("Graph-Editor", oldKey);
+                        if (oldCredential != null)
+                        {
+                            oldCredential.RetrievePassword();
+                            vault.Add(new PasswordCredential("Graph-Editor", newKey, oldCredential.Password));
+                            Debug.WriteLine($"Migrated confidential setting: {oldKey} -> {newKey}");
+                        }
+                    }
+                    catch
+                    {
+                    }
+                }
+                catch (Exception ex)
+                {
+                    Debug.WriteLine($"Failed to migrate confidential setting {setting}: {ex.Message}");
+                }
+            }
+        }
+
         public static T GetSetting<T>(Settings Key, T DefaultValue)
         {
-            if (string.IsNullOrEmpty(Key.ToString())) {
+            string settingKey = GetSettingKey(Key);
+
+            if (string.IsNullOrEmpty(settingKey)) {
                 return DefaultValue;
             }
 
             try
             {
                 var localSettings = ApplicationData.Current.LocalSettings;
-                if (localSettings.Values.ContainsKey(Key.ToString()))
+                if (localSettings.Values.ContainsKey(settingKey))
                 {
-                    return (T)localSettings.Values[Key.ToString()];
+                    return (T)localSettings.Values[settingKey];
                 }
                 else
                 {
@@ -122,8 +253,9 @@ public static void SaveSetting(Settings Key, object Value)
                     throw new Exception("Use SaveConfidentialSetting to save password.");
                 }
 
+                string settingKey = GetSettingKey(Key);
                 var localSettings = ApplicationData.Current.LocalSettings;
-                localSettings.Values[Key.ToString()] = Value;
+                localSettings.Values[settingKey] = Value;
             }
             catch
             {
@@ -134,10 +266,11 @@ public static void SaveSetting(Settings Key, object Value)
         public static string GetConfidentialSetting(Settings Key, String DefaultValue)
         {
             var vault = new PasswordVault();
+            string settingKey = GetSettingKey(Key);
 
             try
             {
-                var passwordCredential = vault.Retrieve("Graph-Editor", Key.ToString());
+                var passwordCredential = vault.Retrieve("Graph-Editor", settingKey);
 
                 if (passwordCredential != null)
                 {
@@ -160,8 +293,9 @@ public static void SaveConfidentialSetting(Settings Key, string Value)
         {
             try
             {
+                string settingKey = GetSettingKey(Key);
                 var vault = new PasswordVault();
-                vault.Add(new PasswordCredential("Graph-Editor", Key.ToString(), Value));
+                vault.Add(new PasswordCredential("Graph-Editor", settingKey, Value));
             }
             catch
             {
@@ -287,26 +421,88 @@ public static LanguageInfo[] SupportedLanguages
 
         public enum Settings
         {
+            /// <summary>Authentication Wizard: Previously used authentication flow</summary>
+            [SettingKey("a1b2c3d4-e5f6-4a7b-8c9d-0e1f2a3b4c5d")]
             AccessTokenWizardMethodSelectionPage__RadioButtons_Method__SelectedIndex,
+
+            /// <summary>Authentication Wizard: Previously used scopes</summary>
+            [SettingKey("b2c3d4e5-f6a7-4b8c-9d0e-1f2a3b4c5d6e")]
             AccessTokenWizardBuiltInPage_LastSelectedScopes,
+
+            /// <summary>Authentication Wizard: Previously used tenant name</summary>
+            [SettingKey("c3d4e5f6-a7b8-4c9d-0e1f-2a3b4c5d6e7f")]
             AccessTokenWizardClientSecretPage__TextBox_TenantName__Text,
+
+            /// <summary>Authentication Wizard: Previously used application ID</summary>
+            [SettingKey("d4e5f6a7-b8c9-4d0e-1f2a-3b4c5d6e7f8a")]
             AccessTokenWizardClientSecretPage__TextBox_ApplicationId__Text,
+
+            /// <summary>Authentication Wizard: Previously used client secret</summary>
+            [SettingKey("e5f6a7b8-c9d0-4e1f-2a3b-4c5d6e7f8a9b")]
             AccessTokenWizardClientSecretPage__PasswordBox_ClientSecret__Password,
+
+            /// <summary>Global Setting: Enable request/response logging</summary>
+            [SettingKey("f6a7b8c9-d0e1-4f2a-3b4c-5d6e7f8a9b0c")]
             GlobalSetting_RequestAndResponseLoggingEnabled,
+
+            /// <summary>Global Setting: Request/response log folder path</summary>
+            [SettingKey("a7b8c9d0-e1f2-4a3b-4c5d-6e7f8a9b0c1d")]
             GlobalSetting_RequestAndResponseLoggingFolderPath,
+
+            /// <summary>Global Setting: Request/response log retention days</summary>
+            [SettingKey("b8c9d0e1-f2a3-4b4c-5d6e-7f8a9b0c1d2e")]
             GlobalSetting_RequestAndResponseLoggingRetentionDays,
+
+            /// <summary>Global Setting: Disable logging when app restarts</summary>
+            [SettingKey("c9d0e1f2-a3b4-4c5d-6e7f-8a9b0c1d2e3f")]
             GlobalSetting_DisableRequestAndResponseLoggingWhenAppRestart,
+
+            /// <summary>Global Setting: Exclude Authorization header when logging</summary>
+            [SettingKey("d0e1f2a3-b4c5-4d6e-7f8a-9b0c1d2e3f4a")]
             GlobalSetting_ExcludeAuthorizationHeader,
+
+            /// <summary>Global Setting: Display language override</summary>
+            [SettingKey("e1f2a3b4-c5d6-4e7f-8a9b-0c1d2e3f4a5b")]
             GlobalSetting_DisplayLanguageOverride,
+
+            /// <summary>Global Setting: Maximum execution record count</summary>
+            [SettingKey("f2a3b4c5-d6e7-4f8a-9b0c-1d2e3f4a5b6c")]
             GlobalSetting_MaxExecutionRecordCount,
+
+            /// <summary>Global Setting: Encode plus character</summary>
+            [SettingKey("a3b4c5d6-e7f8-4a9b-0c1d-2e3f4a5b6c7d")]
             GlobalSetting_EncodePlusCharacter,
+
+            /// <summary>Global Setting: Encode sharp character</summary>
+            [SettingKey("b4c5d6e7-f8a9-4b0c-1d2e-3f4a5b6c7d8e")]
             GlobalSetting_EncodeSharpCharacter,
+
+            /// <summary>Global Setting: Request sending confirmation (GET)</summary>
+            [SettingKey("c5d6e7f8-a9b0-4c1d-2e3f-4a5b6c7d8e9f")]
             GlobalSetting_RequestSendingConfirmation_GET,
+
+            /// <summary>Global Setting: Request sending confirmation (POST)</summary>
+            [SettingKey("d6e7f8a9-b0c1-4d2e-3f4a-5b6c7d8e9f0a")]
             GlobalSetting_RequestSendingConfirmation_POST,
+
+            /// <summary>Global Setting: Request sending confirmation (PUT)</summary>
+            [SettingKey("e7f8a9b0-c1d2-4e3f-4a5b-6c7d8e9f0a1b")]
             GlobalSetting_RequestSendingConfirmation_PUT,
+
+            /// <summary>Global Setting: Request sending confirmation (PATCH)</summary>
+            [SettingKey("f8a9b0c1-d2e3-4f4a-5b6c-7d8e9f0a1b2c")]
             GlobalSetting_RequestSendingConfirmation_PATCH,
+
+            /// <summary>Global Setting: Request sending confirmation (DELETE)</summary>
+            [SettingKey("a9b0c1d2-e3f4-4a5b-6c7d-8e9f0a1b2c3d")]
             GlobalSetting_RequestSendingConfirmation_DELETE,
+
+            /// <summary>Global Setting: Custom scopes</summary>
+            [SettingKey("b0c1d2e3-f4a5-4b6c-7d8e-9f0a1b2c3d4e")]
             GlobalSetting_CustomScopes,
+
+            /// <summary>Main Editor: Allow automatic redirect</summary>
+            [SettingKey("c1d2e3f4-a5b6-4c7d-8e9f-0a1b2c3d4e5f")]
             MainEditorLoggingHandler_AllowAutoRedirect
         }
     }