WAT-4234 Migrate to strict TypeScript

.github/workflows/node.js.yml

@@ -27,7 +27,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
     - run: npm ci
-    - run: npm run build
+    - run: npm run build:main
     - run: npm run test:ci
 
     - name: Coveralls

.gitignore

@@ -15,3 +15,6 @@ node_modules
 lerna-debug.log
 
 .DS_Store
+.tsbuildinfo
+
+c8-cov/

core/api/src/run.ts

@@ -6,11 +6,11 @@ import {testAPIController} from './test-api-controller';
 
 type TestFunction = (api: TestContext) => void | Promise<any>;
 
-export function beforeRun(callback) {
+export function beforeRun(callback: (...args: any[]) => any) {
     testAPIController.registerBeforeRunCallback(callback);
 }
 
-export function afterRun(callback) {
+export function afterRun(callback: (...args: any[]) => any) {
     testAPIController.registerAfterRunCallback(callback);
 }
 
@@ -44,7 +44,7 @@ export async function run(...tests: Array<TestFunction>) {
 
         passed = true;
     } catch (error) {
-        catchedError = restructureError(error);
+        catchedError = restructureError(error as Error);
     } finally {
         if (passed) {
             loggerClient.endStep(testID, 'Test passed');
@@ -53,7 +53,7 @@ export async function run(...tests: Array<TestFunction>) {
         } else {
             loggerClient.endStep(testID, 'Test failed', catchedError);
 
-            await bus.failedTest(catchedError);
+            await bus.failedTest(catchedError as Error);
         }
     }
 }

core/api/tsconfig.build.json

@@ -0,0 +1,10 @@
+{
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+      "outDir": "dist",
+      "rootDir": "src",
+      "noEmit": false,
+      "composite": true
+    },
+    "exclude": ["test"]
+  }

core/api/tsconfig.json

@@ -1,35 +1,8 @@
 {
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "target": "es2015",
-    "module": "commonjs",
-    "allowJs": false,
-    "moduleResolution": "node",
-    "noFallthroughCasesInSwitch": true,
-    "allowSyntheticDefaultImports": true,
-    "preserveConstEnums": true,
-    "noEmitOnError": true,
-    "declaration": false,
-    "outDir": "dist",
-    "sourceMap": true,
-    "lib": [
-      "es5",
-      "es2015",
-      "es2016",
-      "es2017",
-      "dom"
-    ],
-
-    "noUnusedLocals": true,
-    "strictNullChecks": true,
-    "removeComments": false
+    "rootDir": ".",
+    "noEmit": true
   },
-  "include": [
-    "*.ts",
-    "src/**/*.ts",
-    "src/**/*.json"
-  ],
-  "exclude": [
-    "./node_modules",
-    "../../node_modules"
-  ]
-}
+  "include": ["src", "test"]
+}

core/async-assert/src/index.ts

@@ -8,23 +8,23 @@ type AssertionAPI = typeof chai['assert'] & {
 };
 type WrappedPromisedAssertionApi = PromisedAssert & {
     [errorMessagesField]: Array<string>;
-};
+} & AssertionAPI;
 
 export function createAssertion(options: IAssertionOptions = {}) {
     const isSoft = options.isSoft === true;
     for (const plugin of options.plugins || []) {
         chai.use(plugin);
     }
     // eslint-disable-next-line sonarjs/cognitive-complexity
-    const proxyGetter = (target, fieldName: string) => {
+    const proxyGetter = (target: AssertionAPI, fieldName: string) => {
         if (fieldName === errorMessagesField) {
             return target[errorMessagesField];
         }
 
         const typeOfAssert = isSoft ? 'softAssert' : 'assert';
 
-        const originalMethod = chai.assert[fieldName];
-        const methodAsString = target[fieldName]
+        const originalMethod = (chai.assert as any)[fieldName];
+        const methodAsString = (target as any)[fieldName]
             .toString()
             .replace(/((\/\/.*$)|(\/\*[\s\S]*?\*\/))/gm, '');
         const stringStart = methodAsString.indexOf('(') + 1;
@@ -33,7 +33,7 @@ export function createAssertion(options: IAssertionOptions = {}) {
             methodAsString.slice(stringStart, stringEnd).match(/([^\s,]+)/g) ||
             [];
 
-        return async (...args) => {
+        return async (...args: any[]) => {
             const successMessage =
                 originalMethod.length === args.length ? args.pop() : '';
             const assertArguments: Array<any> = [];
@@ -45,7 +45,7 @@ export function createAssertion(options: IAssertionOptions = {}) {
                     break;
                 }
 
-                const replacer = (k, v) =>
+                const replacer = (_k: any, v: any) =>
                     Object.prototype.toString.call(v) === '[object RegExp]'
                         ? v.toString()
                         : v;
@@ -72,25 +72,25 @@ export function createAssertion(options: IAssertionOptions = {}) {
                     });
                 }
             } catch (error) {
-                const errorMessage = error.message;
+                const errorMessage = (error as Error).message;
                 let handleError: void | Error | null = null;
 
-                error.message = successMessage || assertMessage || errorMessage;
+                (error as Error).message = successMessage || assertMessage || errorMessage;
 
                 if (options.onError) {
                     handleError = await options.onError({
                         isSoft,
                         successMessage,
                         assertMessage,
                         errorMessage,
-                        error,
+                        error: (error instanceof Error) ? error : new Error(String(error)),
                         args,
                         originalMethod: fieldName,
                     });
                 }
 
                 if (!handleError) {
-                    handleError = error;
+                    handleError = error as Error;
                 }
 
                 if (isSoft) {

core/async-assert/test/assert.spec.ts

@@ -109,7 +109,7 @@ describe('assertion functional', () => {
 
     it('should call onError assertion callback without changed error object', async () => {
         const assert = createAssertion({
-            onError: (meta) => {
+            onError: (_meta) => {
                 /* empty */
             },
         });
@@ -118,22 +118,22 @@ describe('assertion functional', () => {
             await assert.equal(1, 2);
         } catch (error) {
             chai.expect(error).to.be.an.instanceof(Error);
-            chai.expect(error.message).to.be.eq(
+            chai.expect((error as Error).message).to.be.eq(
                 '[assert] equal(act = 1, exp = 2)',
             );
         }
     });
 
     it('should call onError assertion callback with different Error', async () => {
         const overloadMessage = 'Overloaded message';
-        let originalError;
+        let originalError: Error | undefined;
 
         const assert = createAssertion({
             onError: (meta) => {
                 const tmpErr = new Error();
                 originalError = meta.error;
                 tmpErr.message = overloadMessage;
-                tmpErr.stack = meta.error.stack;
+                tmpErr.stack = meta.error?.stack ?? '';
 
                 return tmpErr;
             },
@@ -143,8 +143,8 @@ describe('assertion functional', () => {
             await assert.equal(1, 2);
         } catch (error) {
             chai.expect(error).to.be.an.instanceof(Error);
-            chai.expect(error.message).to.be.eq(overloadMessage);
-            chai.expect(error.stack).to.be.eq(originalError.stack);
+            chai.expect((error as Error).message).to.be.eq(overloadMessage);
+            chai.expect((error as Error).stack).to.be.eq(originalError?.stack);
         }
     });
 });

core/async-assert/tsconfig.build.json

@@ -0,0 +1,10 @@
+{
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+      "outDir": "dist",
+      "rootDir": "src",
+      "noEmit": false,
+      "composite": true
+    },
+    "exclude": ["test"]
+  }

core/async-assert/tsconfig.json

@@ -1,35 +1,8 @@
 {
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "target": "es2015",
-    "module": "commonjs",
-    "allowJs": false,
-    "moduleResolution": "node",
-    "noFallthroughCasesInSwitch": true,
-    "allowSyntheticDefaultImports": true,
-    "preserveConstEnums": true,
-    "noEmitOnError": true,
-    "declaration": false,
-    "outDir": "dist",
-    "sourceMap": true,
-    "lib": [
-      "es5",
-      "es2015",
-      "es2016",
-      "es2017",
-      "dom"
-    ],
-
-    "noUnusedLocals": true,
-    "strictNullChecks": true,
-    "removeComments": false
+    "rootDir": ".",
+    "noEmit": true
   },
-  "include": [
-    "*.ts",
-    "src/**/*.ts",
-    "src/**/*.json"
-  ],
-  "exclude": [
-    "./node_modules",
-    "../../node_modules"
-  ]
-}
+  "include": ["src", "test"]
+}

core/async-breakpoints/src/async-breakpoints.ts

@@ -23,7 +23,7 @@ export class AsyncBreakpoints extends EventEmitter {
         }
 
         const breakpoint = new Promise<void>((resolve, reject) => {
-            const releaseHandler = (resolvedType) => {
+            const releaseHandler = (resolvedType: BreakpointsTypes) => {
                 if (resolvedType === type) {
                     this.clearBreakpoint(type);
                     // eslint-disable-next-line no-use-before-define

core/async-breakpoints/src/break-stack-error.ts

@@ -1,5 +1,5 @@
 export class BreakStackError extends Error {
-    constructor(message) {
+    constructor(message: string) {
         super(message);
         // Ensure the name of this error is the same as the class name
         this.name = this.constructor.name;

core/async-breakpoints/tsconfig.build.json

@@ -0,0 +1,10 @@
+{
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+      "outDir": "dist",
+      "rootDir": "src",
+      "noEmit": false,
+      "composite": true
+    },
+    "exclude": ["test"]
+  }

core/async-breakpoints/tsconfig.json

@@ -1,35 +1,8 @@
 {
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "target": "es2015",
-    "module": "commonjs",
-    "allowJs": false,
-    "moduleResolution": "node",
-    "noFallthroughCasesInSwitch": true,
-    "allowSyntheticDefaultImports": true,
-    "preserveConstEnums": true,
-    "noEmitOnError": true,
-    "declaration": false,
-    "outDir": "dist",
-    "sourceMap": true,
-    "lib": [
-      "es5",
-      "es2015",
-      "es2016",
-      "es2017",
-      "dom"
-    ],
-
-    "noUnusedLocals": true,
-    "strictNullChecks": true,
-    "removeComments": false
+    "rootDir": ".",
+    "noEmit": true
   },
-  "include": [
-    "*.ts",
-    "src/**/*.ts",
-    "src/**/*.json"
-  ],
-  "exclude": [
-    "./node_modules",
-    "../../node_modules"
-  ]
-}
+  "include": ["src", "test"]
+}