Merge pull request #274 from ringcentral/WAT-5677

WAT-5677

Author: ArtMathArt

core/logger/src/logger-server.ts

@@ -56,7 +56,7 @@ export class LoggerServer extends PluggableModule implements ILoggerServer {
     ): Promise<void> {
         const queueItem = this.queue.shift();
 
-        if (queueItem === undefined) {
+        if (!queueItem) {
             this.status = LogQueueStatus.EMPTY;
             return;
         }

core/types/src/utils/index.ts

@@ -13,7 +13,7 @@ export interface IStack<T> {
 export interface IQueue<T> {
     push(...elements: Array<T>): void;
 
-    shift(): T | void;
+    shift(): T | undefined;
 
     clean(): void;
 

core/utils/src/queue.ts

@@ -15,7 +15,7 @@ export class Queue<T> implements IQueue<T> {
         this.array.push(...elements);
     }
 
-    public shift(): T | void {
+    public shift(): T | undefined {
         return this.array.shift();
     }
 

packages/web-application/src/web-application.ts

@@ -19,6 +19,7 @@ import {
     XpathSelector,
     ShadowCssSelector,
     Selector,
+    isXpathSelector,
 } from '@testring/types';
 
 import {asyncBreakpoints} from '@testring/async-breakpoints';
@@ -225,12 +226,18 @@ export class WebApplication extends PluggableModule {
 
         if (this.config.devtool) {
             try {
-                if (normalizedXPath && normalizedXPath.type !== 'xpath') {
-                    throw new Error(
-                        `devtoolHighlight only supports xpath selectors. Received type: ${normalizedXPath.type}, value: ${JSON.stringify(normalizedXPath)}`
-                    );
+                let xpathString: string | null = null;
+
+                if (normalizedXPath) {
+                    if (!isXpathSelector(normalizedXPath)) {
+                        throw new Error(
+                            `devtoolHighlight only supports xpath selectors. Received type: ${normalizedXPath.type}, value: ${JSON.stringify(normalizedXPath)}`
+                        );
+                    }
+
+                    xpathString = normalizedXPath.xpath;
                 }
-                const xpathString = normalizedXPath ? normalizedXPath.xpath : null;
+
                 await this.client.execute((addHighlightXpath: string) => {
                     window.postMessage(
                         {