Skip to content

Commit eaee9c1

Browse files
committed
Change default iceCheckingTimeout to 2s
1 parent 8df4085 commit eaee9c1

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

demo/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,8 @@ $(() => {
177177
enableQos: true,
178178
enableMediaReportLogging: true,
179179

180-
// in some network environments, the default iceCheckingTimeout of 500ms is not enough
181-
// we need more time to gather candidates.
182-
// disadvantage of this is that it will take more time to establish the call
183-
iceCheckingTimeout: 3000, // 3 seconds
180+
// previous default value is 500ms. Now it is 2000ms, so I comment it out
181+
// iceCheckingTimeout: 2000,
184182
};
185183

186184
const urlParams = new URLSearchParams(window.location.search);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ringcentral-web-phone",
3-
"version": "1.0.10",
3+
"version": "1.0.11",
44
"homepage": "https://github.com/ringcentral/ringcentral-web-phone",
55
"bugs": {
66
"url": "https://github.com/ringcentral/ringcentral-web-phone/issues"

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export interface WebPhoneOptions {
129129
enableTurnServers?: boolean;
130130
/** Max time in milliseconds to be considered when generating ice candidates
131131
*
132-
* default value `2000` when `enableTurnServers` is `true`, otherwise `500`
132+
* default value `2000`
133133
*/
134134
iceCheckingTimeout?: number;
135135
/** Policy used when generating ice candidates
@@ -366,7 +366,7 @@ export default class WebPhone {
366366
];
367367

368368
const sessionDescriptionHandlerFactoryOptions = options.sessionDescriptionHandlerFactoryOptions || {
369-
iceGatheringTimeout: options.iceCheckingTimeout || 500,
369+
iceGatheringTimeout: options.iceCheckingTimeout || 2000,
370370
enableDscp: options.enableDscp,
371371
peerConnectionConfiguration: {
372372
iceServers,

0 commit comments

Comments
 (0)