Skip to content

fix(logger): fix logger storage prune issue #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unadlib merged 2 commits into from
Apr 25, 2025
Merged

fix(logger): fix logger storage prune issue #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf19db
fix(logger): fix logger storage prune issue
unadlib Apr 25, 2025
261f8c6
fix: update
unadlib Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/logger/src/transports/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class StorageTransport implements ITransport {
// only prune logs if total size is greater than maxLogsSize
const totalLogSize = await this._getTotalSize();
if (totalLogSize > this.maxLogsSize) {
let sizeOverBy = totalLogSize - this.maxLogsSize;
let sizeOverBy = this.maxLogsSize;
let cutoffTime = 0;

try {
Expand All @@ -316,9 +316,8 @@ export class StorageTransport implements ITransport {
.reverse()
.each((log: Logs) => {
sizeOverBy -= log.size;
if (sizeOverBy <= 0) {
if (sizeOverBy <= 0 && cutoffTime === 0) {
cutoffTime = log.time;
Comment thread
unadlib marked this conversation as resolved.
throw new Error('cutoff found');
}
});
} catch (_) {
Expand Down