Fix more lint issues

Author: tylerlong

biome.json

@@ -16,7 +16,10 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "style": {
+        "noNonNullAssertion": "off"
+      }
     }
   }
 }

package.json

@@ -16,7 +16,7 @@
     "prepublishOnly": "yarn reset && yarn compile && yarn test",
     "test": "yarn workspace @rc-ex/test run vitest",
     "upgrade-all": "yarn-upgrade-all -W && yarn workspaces run yarn-upgrade-all && yarn install",
-    "format-lint": "biome check --write ."
+    "format-lint": "biome check --write --unsafe ."
   },
   "devDependencies": {
     "@biomejs/biome": "^2.4.10",

packages/extensions/events/src/index.ts

@@ -1,3 +1,4 @@
+import { EventEmitter } from "node:events";
 import type RingCentral from "@rc-ex/core";
 import type GetTokenRequest from "@rc-ex/core/definitions/GetTokenRequest";
 import RestException from "@rc-ex/core/RestException";
@@ -7,7 +8,6 @@ import type {
   RestRequestConfig,
   RestResponse,
 } from "@rc-ex/core/types";
-import { EventEmitter } from "events";
 
 export enum Events {
   beforeRequest = "beforeRequest",

packages/extensions/retry/src/index.ts

@@ -30,7 +30,7 @@ class RetryExtension extends SdkExtension {
     this.options.shouldRetry ??= (restException, retriesAttempted) =>
       retriesAttempted < 3 &&
       [429, 503].includes(restException.response.status);
-    this.options.retryInterval ??= (restException, retriesAttempted) =>
+    this.options.retryInterval ??= (_restException, retriesAttempted) =>
       60 * 1000 * 2 ** retriesAttempted; // exponential back off
   }
 

packages/extensions/ws/src/index.ts

@@ -1,3 +1,4 @@
+import { EventEmitter } from "node:events";
 import type RingCentral from "@rc-ex/core";
 import type SubscriptionInfo from "@rc-ex/core/definitions/SubscriptionInfo";
 import RestException from "@rc-ex/core/RestException";
@@ -7,7 +8,6 @@ import type {
   RestRequestConfig,
   RestResponse,
 } from "@rc-ex/core/types";
-import { EventEmitter } from "events";
 import hyperid from "hyperid";
 import type { MessageEvent } from "isomorphic-ws";
 import WS from "isomorphic-ws";
@@ -233,7 +233,7 @@ class WebSocketExtension extends SdkExtension {
     if (this.ws?.readyState === OPEN || this.ws?.readyState === CONNECTING) {
       return;
     }
-    if (!this.wsc || !this.wsc.token) {
+    if (!this.wsc?.token) {
       await this.connect(false); // connect to WSG but do not recover
       return;
     }
@@ -275,7 +275,7 @@ class WebSocketExtension extends SdkExtension {
           },
         ]),
       );
-    } catch (e) {
+    } catch (_e) {
       this.ws.close(); // Explicitly mark WS as closed
     }
   }
@@ -367,7 +367,7 @@ class WebSocketExtension extends SdkExtension {
     this.eventEmitter.emit(Events.connectionReady, this.ws);
 
     // recover the subscription, if it exists and enabled
-    if (this.subscription && this.subscription.enabled) {
+    if (this.subscription?.enabled) {
       // because we have a new ws object
       this.subscription.setupWsEventListener();
       if (

test/a2p.spec.ts

@@ -1,6 +1,6 @@
+import path from "node:path";
 import DebugExtension from "@rc-ex/debug";
 import dotenv from "dotenv-override-true";
-import path from "path";
 import { describe, expect, test } from "vitest";
 
 import ReusableRestClient from "./reusable-rest-client";

test/debug-extension.spec.ts

@@ -1,5 +1,5 @@
 import DebugExtension from "@rc-ex/debug";
-import { describe, expect, test } from "vitest";
+import { describe, test } from "vitest";
 
 import ReusableRestClient from "./reusable-rest-client";
 

test/download-fax.spec.ts

@@ -1,5 +1,5 @@
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 import { describe, expect, test } from "vitest";
 
 import ReusableRestClient from "./reusable-rest-client";

test/events-extension.spec.ts

@@ -1,6 +1,6 @@
 import Utils from "@rc-ex/core/Utils";
 import EventsExtension, { Events } from "@rc-ex/events";
-import { describe, expect, test } from "vitest";
+import { describe, test } from "vitest";
 
 import ReusableRestClient from "./reusable-rest-client";
 

test/exceptions.spec.ts

@@ -1,4 +1,3 @@
-import RestException from "@rc-ex/core/RestException";
 import type { RestResponse } from "@rc-ex/core/types";
 import { describe, expect, test } from "vitest";