Allow empty PIN

[truelockmc]

It would be quite useful if you wouldnt HAVE to enter a PIN for each Player.

When I play this Game with friends I can trust them with not looking a the cards of the others and it's a bit annoying if everyone has to set and enter a PIN.
So I would prefer this to be optional.

[devdan]

Yes! That's what I thought, too. Maybe have an option to disable PIN altogether. Would you accept a PR for that? If yes, what would you prefer? Disable PIN or allow empty PIN?

[retired64]

Hey everyone! 👋
@truelockmc

Great suggestion I totally agree this would improve the experience. Feel free to go ahead and implement it! I'd personally lean towards having an option to disable PIN altogether, but I'm open to whatever approach you think works best.

Once you have a PR ready, I'll be keeping an eye on it and will make sure to review and merge it promptly. Thanks so much for contributing, really appreciate it!

[truelockmc]

I'll post a draft in the next few days 👍

[truelockmc]

I made a simple version to test the design:

PIN enabled:

PIN disabled:

What do you think, is generally placing the toggle there (and making it look like this) a good idea?
Should the player count still be centered?

I guess it would be cleaner too if the PIN dots weren't shown after saving, if there is no PIN.

[retired64]

@truelockmc Looks good! Though we could improve the user experience a bit it'd be great to make it clearer that toggling that option lets you set your PIN. Some visual feedback in the UI would go a long way. The idea is solid, it just feels like it needs a bit more visual guidance to really tie it together.
About the dots after saving you're right! Let's remove them if there's no PIN set.