Merge pull request #38 from reach2jeyan/37-screenshot-not-attached-in-selenium

Bug fixes

Author: reach2jeyan

README.md

@@ -28,6 +28,16 @@ You’ll get:
 
 report.html – a clean, styled HTML report
 
+---
+## Available Options
+| Option                  | Description                                                        | Default                  | Choices                          |
+| ----------------------- | ------------------------------------------------------------------ | ------------------------ |----------------------------------|
+| `--json-report`         | Path to save individual JSON test reports                          | `playwright_report.json` | *Any valid file path*            |
+| `--automation-tool`     | Specify automation tool used for testing                           | `playwright`             | `playwright`, `selenium`, `other` |
+| `--capture-screenshots` | When to capture screenshots                                        | `failed`                 | `failed`, `all`, `none`          |
+| `--html-output`         | Directory to output HTML reports                                   | `report_output`          | *Any valid directory*            |
+| `--screenshots`         | Directory where screenshots will be stored                         | `screenshots`            | *Any valid directory*            |
+| `--send-email`          | Send HTML report via email after the test run                      | `False`                  | `True`, `False`                  |
 ---
 
 ## ✨ Features
@@ -71,28 +81,12 @@ Just start typing, and the dashboard will instantly filter tests by:
 
 ![Screen Recording 2025-06-01 at 2 48 08 PM](https://github.com/user-attachments/assets/057441ac-06a3-421f-aafc-915968a90463)
 
-
-
-
----
-
 ##  Why use pytest-reporter-plus?
 Stop wasting time writing and maintaining custom pytest reporter hooks like pytest_runtest_makereport!
 With pytest-reporter-plus, you get a beautiful, lightweight HTML report out of the box — no extra coding needed.
 
 Just install, run your tests, and let the plugin handle all the reporting magic. Focus on what matters: writing and running your tests.
 
-## Available Options
-| Option                  | Description                                                        | Default                  | Choices                  |
-| ----------------------- | ------------------------------------------------------------------ | ------------------------ | ------------------------ |
-| `--json-report`         | Path to save individual JSON test reports                          | `playwright_report.json` | *Any valid file path*    |
-| `--automation-tool`     | Specify automation tool used for testing                           | `playwright`             | `playwright`, `selenium` |
-| `--capture-screenshots` | When to capture screenshots                                        | `failed`                 | `failed`, `all`, `none`  |
-| `--html-output`         | Directory to output HTML reports                                   | `report_output`          | *Any valid directory*    |
-| `--screenshots`         | Directory where screenshots will be stored                         | `screenshots`            | *Any valid directory*    |
-| `--send-email`          | Send HTML report via email after the test run                      | `False`                  | `True`, `False`          |
-| `--detect-flake`        | Detect flaky tests based on reruns in the current or last few runs | `False`                  | `True`, `False`          |
-
 
 ## 🔁 Flaky Test Detection
 If a test is retried multiple times (e.g. due to a --reruns plugin), the report will flag it as FLAKY.
@@ -103,9 +97,8 @@ In the HTML report, you’ll see a badge like:
 
 
 ## 📧 Email Report (Optional)
-Send the HTML report via email using --send-email.
+Send the HTML report via email using --send-email. Please note you will need your own sendgrid setup to use this feature
 
-### Setup Environment Variables
 Create an emailenv file in your project folder that has the following
 
 ```commandline

pyproject.toml

@@ -1,11 +1,20 @@
 [tool.poetry]
 name = "pytest-reporter-plus"
-version = "0.2.1"
+version = "0.2.2"
 description = "Lightweight enhanced HTML reporter for Pytest"
 readme = "README.md"
 authors = ["Emjey","Karan"]
 license = "MIT"
 packages = [{ include = "pytest_reporter_plus" }]
+keywords = [
+  "html",
+  "pytest",
+  "report",
+]
+
+urls.Homepage = "https://github.com/reach2jeyan/pytest-report-plus"
+urls.Source = "https://github.com/reach2jeyan/pytest-report-plus"
+urls.Tracker = "https://github.com/reach2jeyan/pytest-report-plus/issues"
 
 [tool.poetry.dependencies]
 python = ">=3.9"

pytest_reporter_plus/plugin.py

@@ -58,7 +58,12 @@ def pytest_runtest_makereport(item, call):
                     or getattr(item, "page_for_screenshot", None)
             )
             if driver:
-                screenshot_path = take_screenshot_on_failure(item, driver)
+                if tool == "playwright":
+                    screenshot_path = take_screenshot_on_failure(item, driver)
+                elif tool == "selenium":
+                    screenshot_path = take_screenshot_selenium(item, driver)
+                else:
+                    pass
         reporter = config._json_reporter
         worker_id = os.getenv("PYTEST_XDIST_WORKER") or "main"
         reporter.log_result(
@@ -178,7 +183,7 @@ def pytest_addoption(parser):
         "--automation-tool",
         action="store",
         default="playwright",
-        choices=["selenium", "playwright"],
+        choices=["selenium", "playwright", "other"],
         help="Specify automation tool: selenium (default) or playwright"
     )
     parser.addoption(

tests/selenium_initial_test.py

@@ -0,0 +1,23 @@
+import pytest
+from selenium import webdriver
+from selenium.webdriver.chrome.options import Options
+from selenium.webdriver.common.by import By
+import os
+
+@pytest.fixture(scope="function")
+def driver():
+    options = Options()
+    options.add_argument('--headless')
+    options.add_argument('--no-sandbox')
+    driver = webdriver.Chrome(options=options)
+    yield driver
+    driver.quit()
+
+def test_title_should_pass(driver):
+    driver.get("https://example.com")
+    assert "Example Domain" in driver.title
+
+def test_text_should_fail(driver):
+    driver.get("https://example.com")
+    elem = driver.find_element(By.TAG_NAME, "h1")
+    assert elem.text == "Not the correct heading"  # This will fail