[Feature request]: Optionally choosing between old and new death player animations

[Den555By]

👉👈 Contact Details (optional)

No response

💡 Tell us more about your idea

I prefer to use old animations a want enabling/disabling it as option

[dystopm]

Could you elaborate a bit more on your request? Apparently (and related to the SetAnimation func) there are no significant changes to the death anims; in fact, models are the same. I'm guessing you're referring to animations.

[Den555By]

Yes, I mean animations, if compare old mp and new, there's changes how dead players model sometimes falls

[dystopm]

Yes, I mean animations, if compare old mp and new, there's changes how dead players model sometimes falls

By checking regamedll code and original (disassembled) code, animations are the same. Try to prove your point with a video or something, because (1) models were not changed and (2) death animations are the same - there's no "fixed" code in SetAnimation related to animation assignation

[Den555By]

Well, im sorry, i mean how players models fall sometimes

Here is old mp.dll. Notice how players models falls only on side direction. if headshot was made from side, sometimes in opposite direction from was they aimed
https://drive.google.com/file/d/1ViA3aoQQsYSzjja9tt_6gQASpbaTZ4aF/view?usp=drive_link
Now there new mp.dll. In this case players models can fall even in forward direction or other direction, which is looks kinda weird...
https://drive.google.com/file/d/1rDZPDNeFfAHj7I9P0r3RvFKoYu7WgO-X/view?usp=drive_link

[dystopm]

Headshots provokes body goes in random directions. Check yourself this code (from regamedll), which I personally checked is the same as the original dll:

ReGameDLL_CS/regamedll/dlls/player.cpp

Lines 2969 to 3106 in 4dddce6

	case ACT_DIESIMPLE:
	{
	if (m_Activity == m_IdealActivity)
	return;
	m_Activity = m_IdealActivity;
	m_flDeathThrowTime = 0;
	m_iThrowDirection = THROW_NONE;
	switch (m_LastHitGroup)
	{
	case HITGROUP_GENERIC:
	{
	switch (RANDOM_LONG(0, 8))
	{
	case 0:
	animDesired = LookupActivity(ACT_DIE_HEADSHOT);
	m_iThrowDirection = THROW_BACKWARD;
	break;
	case 1:
	animDesired = LookupActivity(ACT_DIE_GUTSHOT);
	break;
	case 2:
	animDesired = LookupActivity(ACT_DIE_BACKSHOT);
	m_iThrowDirection = THROW_HITVEL;
	break;
	case 4:
	animDesired = LookupActivity(ACT_DIEBACKWARD);
	m_iThrowDirection = THROW_HITVEL;
	break;
	case 5:
	animDesired = LookupActivity(ACT_DIEFORWARD);
	m_iThrowDirection = THROW_FORWARD;
	break;
	case 6:
	animDesired = LookupActivity(ACT_DIE_CHESTSHOT);
	break;
	case 7:
	animDesired = LookupActivity(ACT_DIE_GUTSHOT);
	break;
	case 8:
	animDesired = LookupActivity(ACT_DIE_HEADSHOT);
	break;
	default:
	animDesired = LookupActivity(ACT_DIESIMPLE);
	break;
	}
	break;
	}
	case HITGROUP_HEAD:
	{
	int random = RANDOM_LONG(0, 8);
	m_bHeadshotKilled = true;
	if (m_bHighDamage)
	random++;
	switch (random)
	{
	case 1:
	case 2:
	m_iThrowDirection = THROW_BACKWARD;
	break;
	case 3:
	case 4:
	m_iThrowDirection = THROW_FORWARD;
	break;
	case 5:
	case 6:
	m_iThrowDirection = THROW_HITVEL;
	break;
	default:
	m_iThrowDirection = THROW_NONE;
	break;
	}
	animDesired = LookupActivity(ACT_DIE_HEADSHOT);
	break;
	}
	case HITGROUP_CHEST:
	animDesired = LookupActivity(ACT_DIE_CHESTSHOT);
	break;
	case HITGROUP_STOMACH:
	animDesired = LookupActivity(ACT_DIE_GUTSHOT);
	break;
	case HITGROUP_LEFTARM:
	animDesired = LookupSequence("left");
	break;
	case HITGROUP_RIGHTARM:
	{
	m_iThrowDirection = RANDOM_LONG(0, 1) ? THROW_HITVEL : THROW_HITVEL_MINUS_AIRVEL;
	animDesired = LookupSequence("right");
	break;
	}
	default:
	animDesired = LookupActivity(ACT_DIESIMPLE);
	break;
	}
	if (pev->flags & FL_DUCKING)
	{
	animDesired = LookupSequence("crouch_die");
	m_iThrowDirection = THROW_BACKWARD;
	}
	else if (m_bKilledByBomb || m_bKilledByGrenade)
	{
	UTIL_MakeVectors(pev->angles);
	if (DotProduct(gpGlobals->v_forward, m_vBlastVector) > 0.0f)
	animDesired = LookupSequence("left");
	else
	{
	if (RANDOM_LONG(0, 1))
	animDesired = LookupSequence("crouch_die");
	else
	animDesired = LookupActivity(ACT_DIE_HEADSHOT);
	}
	if (m_bKilledByBomb)
	m_iThrowDirection = THROW_BOMB;
	else if (m_bKilledByGrenade)
	m_iThrowDirection = THROW_GRENADE;
	}
	if (animDesired == -1)
	animDesired = 0;
	if (pev->sequence != animDesired)
	{
	pev->gaitsequence = 0;
	pev->sequence = animDesired;
	pev->frame = 0.0f;
	ResetSequenceInfo();
	}
	return;
	}

Also, in CBasePlayer::Killed you can check how the throwing direction applies:

ReGameDLL_CS/regamedll/dlls/player.cpp

Lines 2481 to 2548 in 4dddce6

	if (m_iThrowDirection)
	{
	switch (m_iThrowDirection)
	{
	case THROW_FORWARD:
	{
	UTIL_MakeVectors(pev->angles);
	pev->velocity = gpGlobals->v_forward * RANDOM_FLOAT(100, 200);
	pev->velocity.z = RANDOM_FLOAT(50, 100);
	break;
	}
	case THROW_BACKWARD:
	{
	UTIL_MakeVectors(pev->angles);
	pev->velocity = gpGlobals->v_forward * RANDOM_FLOAT(-100, -200);
	pev->velocity.z = RANDOM_FLOAT(50, 100);
	break;
	}
	case THROW_HITVEL:
	{
	if (FClassnameIs(pevAttacker, "player"))
	{
	UTIL_MakeVectors(pevAttacker->angles);
	pev->velocity = gpGlobals->v_forward * RANDOM_FLOAT(200, 300);
	pev->velocity.z = RANDOM_FLOAT(200, 300);
	}
	break;
	}
	case THROW_BOMB:
	{
	// TODO: fix test demo
	pev->velocity = m_vBlastVector * (1.0f / m_vBlastVector.Length()) * float(2300.0f - m_vBlastVector.Length()) * 0.25f;
	pev->velocity.z = (2300.0f - m_vBlastVector.Length()) / 2.75f;
	break;
	}
	case THROW_GRENADE:
	{
	pev->velocity = m_vBlastVector * (1 / m_vBlastVector.Length()) * (500 - m_vBlastVector.Length());
	pev->velocity.z = (350 - m_vBlastVector.Length()) * 1.5;
	break;
	}
	case THROW_HITVEL_MINUS_AIRVEL:
	{
	if (FClassnameIs(pevAttacker, "player"))
	{
	UTIL_MakeVectors(pevAttacker->angles);
	pev->velocity = gpGlobals->v_forward * RANDOM_FLOAT(200, 300);
	}
	break;
	}
	default:
	break;
	}
	// UNDO: This code was intended to set the victim's angle with the throw direction
	// For bots, it works correctly because they do not send angle updates to the server,
	// However, for players, the client overrides the angle with its own view direction in the next frame,
	// causing a visual glitch where the model rotates excessively
	// The issue is more noticeable with high cmdrate values (e.g., cl_cmdrate >100)
	// Disabled to avoid this artifact
	#ifndef REGAMEDLL_FIXES
	pev->angles.y = UTIL_VecToAngles(-pev->velocity).y;
	pev->v_angle.y = pev->angles.y;
	#endif
	m_iThrowDirection = THROW_NONE;
	}

I might say you are searching for this fixed artifact, which describes:

ReGameDLL_CS/regamedll/dlls/player.cpp

Lines 2536 to 2545 in 4dddce6

	// UNDO: This code was intended to set the victim's angle with the throw direction
	// For bots, it works correctly because they do not send angle updates to the server,
	// However, for players, the client overrides the angle with its own view direction in the next frame,
	// causing a visual glitch where the model rotates excessively
	// The issue is more noticeable with high cmdrate values (e.g., cl_cmdrate >100)
	// Disabled to avoid this artifact
	#ifndef REGAMEDLL_FIXES
	pev->angles.y = UTIL_VecToAngles(-pev->velocity).y;
	pev->v_angle.y = pev->angles.y;
	#endif

Because in the video, at most, I managed to distinguish that sometimes in the old gamedll the body takes an unexpected turn, which is the same behavior fixed and described in the comment. Does that makes sense to you? (no spicy comment intended). If that's the case, it is just a body-angle matter, not animations or punch forces.

[Den555By]

Yes, i understand. But, i guess, it should be an option, beacause if made manually adding with every update will be not good