Treat warnings as errors, fix pygit2 ls_remotes deprecation

Replace deprecated Remote.ls_remotes() with Remote.list_heads() and
update ref access from dict subscript to attribute access (RemoteHead).
Configure pytest filterwarnings = ["error"] to catch future deprecations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: refaim

pyproject.toml

@@ -35,6 +35,7 @@ markers = [
     "slow: mark test as slow",
 ]
 addopts = "-m 'not integration'"
+filterwarnings = ["error"]
 
 [dependency-groups]
 dev = [

src/mygit.py

@@ -111,7 +111,7 @@ class RemoteState:
 @dataclass
 class _RemoteLsResult:
     remote: pygit2.Remote
-    refs: list[dict]
+    refs: list
     error: str | None
 
 
@@ -127,7 +127,7 @@ def fetch_states(requests: list[RemoteStateRequest]) -> Iterator[RemoteState]:
 
         def ls(remote: pygit2.Remote) -> _RemoteLsResult:
             try:
-                refs = remote.ls_remotes()
+                refs = remote.list_heads()
                 error = None
             except pygit2.GitError as exception:
                 refs = []
@@ -148,9 +148,9 @@ def ls(remote: pygit2.Remote) -> _RemoteLsResult:
                     else:
                         branch_ref = f"refs/heads/{branch}"
                         for ref in ls_result.refs:
-                            is_head = ref["name"] == "HEAD" and ref["symref_target"] == branch_ref
-                            if is_head or ref["name"] == branch_ref:
-                                yield RemoteState(url, branch, str(ref["oid"]), None)
+                            is_head = ref.name == "HEAD" and ref.symref_target == branch_ref
+                            if is_head or ref.name == branch_ref:
+                                yield RemoteState(url, branch, str(ref.oid), None)
                                 break
 
 

tests/conftest.py

@@ -128,9 +128,9 @@ def _mock_remote(name, url, refs=None, error=None):
         remote.name = name
         remote.url = url
         if error:
-            remote.ls_remotes.side_effect = pygit2.GitError(error)
+            remote.list_heads.side_effect = pygit2.GitError(error)
         else:
-            remote.ls_remotes.return_value = refs or []
+            remote.list_heads.return_value = refs or []
         return remote
 
     return _mock_remote

tests/test_mygit.py

@@ -75,7 +75,7 @@ def test_success_returns_commit_hash(self, mock_remote, mock_pygit2_repo, fetch_
         remote = mock_remote(
             "abc123",
             "https://github.com/test/repo.git",
-            refs=[{"name": "refs/heads/master", "symref_target": "", "oid": "deadbeef"}],
+            refs=[SimpleNamespace(name="refs/heads/master", symref_target="", oid="deadbeef")],
         )
         mock_pygit2_repo.remotes.__iter__ = MagicMock(return_value=iter([remote]))
 
@@ -92,7 +92,7 @@ def test_head_symref_resolves_branch(self, mock_remote, mock_pygit2_repo, fetch_
         remote = mock_remote(
             "abc123",
             "https://github.com/test/repo.git",
-            refs=[{"name": "HEAD", "symref_target": "refs/heads/main", "oid": "cafebabe"}],
+            refs=[SimpleNamespace(name="HEAD", symref_target="refs/heads/main", oid="cafebabe")],
         )
         mock_pygit2_repo.remotes.__iter__ = MagicMock(return_value=iter([remote]))
 
@@ -137,7 +137,7 @@ def test_branch_not_found_in_refs(self, mock_remote, mock_pygit2_repo, fetch_sta
         remote = mock_remote(
             "abc123",
             "https://github.com/test/repo.git",
-            refs=[{"name": "refs/heads/other-branch", "symref_target": "", "oid": "deadbeef"}],
+            refs=[SimpleNamespace(name="refs/heads/other-branch", symref_target="", oid="deadbeef")],
         )
         mock_pygit2_repo.remotes.__iter__ = MagicMock(return_value=iter([remote]))