- added the ability to change the shiny status of pokemon (big thanks to @shearx)

Author: BuildTools

PQSE-GUI/PQSE-GUI/EditPokemon.xaml.cs

@@ -76,67 +76,37 @@ private void LoadStuff()
 
         }
 
+
+        /// <summary>
+        /// HNUGE THANKS TO shearx! Provided this function, Maths, Explaination! Complete god.
+        /// </summary>
+        /// <param name="inputId"></param>
+        /// <param name="inputrr"></param>
+        /// <returns></returns>
         public bool CheckShinyStatus(uint inputId, uint inputrr)
         {
-            uint pokeId = inputId;
-            uint pokeRR = inputrr;
-
-            var id = BitConverter.GetBytes(pokeId);
-            var rr = BitConverter.GetBytes(pokeRR);
-
-            byte[] p1Bytes = new byte[2];
-            p1Bytes[0] = id[0];
-            p1Bytes[1] = id[1];
-            p1Bytes[0] = Convert.ToByte(p1Bytes[0].ToString().PadLeft(16, '0'));
-            p1Bytes[1] = Convert.ToByte(p1Bytes[1].ToString().PadLeft(16, '0'));
-
-            byte[] p2Bytes = new byte[2];
-            p2Bytes[0] = id[2];
-            p2Bytes[1] = id[3];
-            //p2Bytes[0] = Convert.ToByte(p2Bytes[0].ToString().PadLeft(16, '0'));
-            //p2Bytes[1] = Convert.ToByte(p2Bytes[1].ToString().PadLeft(16, '0'));
-
-
-            byte[] p3Bytes = new byte[2];
-            p3Bytes[0] = rr[0];
-            p3Bytes[1] = rr[1];
-            //p3Bytes[0] = Convert.ToByte(p3Bytes[0].ToString().PadLeft(16, '0'));
-            //p3Bytes[1] = Convert.ToByte(p3Bytes[1].ToString().PadLeft(16, '0'));
-
-
-            byte[] p4Bytes = new byte[2];
-            p4Bytes[0] = rr[2];
-            p4Bytes[1] = rr[3];
-            //p4Bytes[0] = Convert.ToByte(p4Bytes[0].ToString().PadLeft(16, '0'));
-            //p4Bytes[1] = Convert.ToByte(p4Bytes[1].ToString().PadLeft(16, '0'));
-
-
-            var r1 = ((p1Bytes[0] << 8) + p1Bytes[1]) ^ ((p2Bytes[0] << 8) + p2Bytes[1]);
-            var r2 = r1 ^ ((p3Bytes[0] << 8) + p3Bytes[1]);
-            var r3 = r2 ^ ((p4Bytes[0] << 8) + p4Bytes[1]);
+            string id = Convert.ToString(inputId, 2).PadLeft(32, '0');
+            string rr = Convert.ToString(inputrr, 2).PadLeft(32, '0');
 
-            //BitArray b = new BitArray(BitConverter.GetBytes(r3));
-            //int[] bits = b.Cast<bool>().Select(bit => bit ? 1 : 0).ToArray();
+            string target = Convert.ToString(14, 2).PadLeft(16, '0');
+            BitArray targetVal = new BitArray(target.Select(s => s == '1').ToArray());
 
-            byte[] bt = BitConverter.GetBytes(r3);
+            BitArray p1 = new BitArray(id.Substring(0, 16).Select(s => s == '1').ToArray());
+            BitArray p2 = new BitArray(id.Substring(16, 16).Select(s => s == '1').ToArray());
+            BitArray p3 = new BitArray(rr.Substring(0, 16).Select(s => s == '1').ToArray());
+            BitArray p4 = new BitArray(rr.Substring(16, 16).Select(s => s == '1').ToArray());
 
-            string strBin = string.Empty;
-            byte btindx = 0;
-            string strAllbin = string.Empty;
+            var r1 = p1.Xor(p2);
+            var r2 = r1.Xor(p3);
+            var r3 = r2.Xor(p4);
 
-            for (int i = 0; i < bt.Length; i++)
+            for (var i = 0; i < r3.Length; i++)
             {
-                btindx = bt[i];
-
-                strBin = Convert.ToString(btindx, 2); // Convert from Byte to Bin
-                //strBin = strBin.PadLeft(4, '0');  // Zero Pad
-
-                strAllbin += strBin;
+                if (r3[i] != targetVal[i])
+                    return false;
             }
+            return true;
 
-            if (strAllbin.StartsWith("0111"))
-                return true;
-            return false;
         }
 
         /// <summary>
@@ -248,30 +218,6 @@ private void InitPStones()
 
         internal SaveCharacterData GetPokeResult()
         {
-            // name
-            // level
-            // exp
-            // monsterNo
-            // (shiny)
-            // attack
-            // health
-            // pstones
-            // (skill stones)
-            // skills
-
-            pokeResult.attack = Convert.ToInt32(pokemonAttack.Text);
-            pokeResult.exp = (uint)Convert.ToInt32(pokemonExp.Text);
-            //pokeResult.formNo
-            pokeResult.hp = Convert.ToInt32(pokemonHealth.Text);
-            //pokeResult.id
-            //pokeResult.isEvolve
-            pokeResult.level = (ushort)Convert.ToInt32(pokemonLevel.Text);
-            pokeResult.monsterNo = (ushort)Convert.ToInt32(comboAllPoke.SelectedIndex + 1);
-            pokeResult.name = pokemonName.Text.ToList();
-            SavePStoneTypes();
-            //pokeResult.rareRandom = (uint)Convert.ToInt32(pokemonRR.Text);
-            //pokeResult.seikaku = (byte)Convert.ToInt32(pokemonSeikaku.Text);
-            //pokeResult.trainingSkillCount
             return pokeResult;
         }
 
@@ -290,30 +236,41 @@ private void SavePStoneTypes()
 
         private void Button_Click(object sender, RoutedEventArgs e)
         {
+            pokeResult.attack = Convert.ToInt32(pokemonAttack.Text);
+            pokeResult.exp = (uint)Convert.ToInt32(pokemonExp.Text);
+            //pokeResult.formNo
+            pokeResult.hp = Convert.ToInt32(pokemonHealth.Text);
+            //pokeResult.id
+            //pokeResult.isEvolve
+            pokeResult.level = (ushort)Convert.ToInt32(pokemonLevel.Text);
+            pokeResult.monsterNo = (ushort)Convert.ToInt32(comboAllPoke.SelectedIndex + 1);
+            pokeResult.name = pokemonName.Text.ToList();
+            SavePStoneTypes();
+            //pokeResult.rareRandom = (uint)Convert.ToInt32(pokemonRR.Text);
+            //pokeResult.seikaku = (byte)Convert.ToInt32(pokemonSeikaku.Text);
+            //pokeResult.trainingSkillCount
+
+
+
             this.DialogResult = true;
         }
 
         private void setToShiny_Click(object sender, RoutedEventArgs e)
         {
             Random rnd = new Random();
             bool foundShinyVals = false;
-            uint shinyValId = 0;
             uint shinyValRR = 0;
 
-            while(foundShinyVals == false)
+            while (foundShinyVals == false)
             {
-                uint randId = (uint)rnd.Next(Int32.MaxValue);
-                uint randRR = (uint)rnd.Next(999999999);
-                if (CheckShinyStatus(randId, randRR) == true)
+                uint randRR = (uint)rnd.Next(int.MaxValue);
+                if (CheckShinyStatus(pokeResult.id, randRR) == true)
                 {
-                    shinyValId = randId;
                     shinyValRR = randRR;
                     foundShinyVals = true;
                     //MessageBox.Show("Found shiny value: " + System.Environment.NewLine + "id: " + randId + System.Environment.NewLine + "rareRandom: " + randRR);
                 }
             }
-
-            pokeResult.id = shinyValId;
             pokeResult.rareRandom = shinyValRR;
             LoadStuff();
         }