Skip to content

Commit 5b3fa0f

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Use umbrellas instead of direct includes in rendererdebug module (#58619)
Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Differential Revision: D121001495
1 parent 330e010 commit 5b3fa0f

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

packages/react-native/ReactCommon/react/renderer/debug/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ add_library(react_renderer_debug OBJECT ${react_renderer_debug_SRC})
1313

1414
target_include_directories(react_renderer_debug PUBLIC ${REACT_COMMON_DIR})
1515
target_include_directories(react_renderer_debug INTERFACE ${REACT_COMMON_DIR}/react/renderer/debug)
16-
target_link_libraries(react_renderer_debug folly_runtime react_cxxstableapi react_debug)
16+
target_link_libraries(react_renderer_debug folly_runtime react_cxxstableapi react_debug react_utils)
1717
target_compile_reactnative_options(react_renderer_debug PRIVATE)
1818
target_compile_options(react_renderer_debug PRIVATE -Wpedantic)
1919

packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
4242
resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_rendererdebug")
4343

4444
add_dependency(s, "React-debug")
45+
add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
4546
add_rn_third_party_dependencies(s)
4647
add_rncore_dependency(s)
4748

packages/react-native/ReactCommon/react/renderer/debug/debugStringConvertibleUtils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
#include <optional>
1414
#include <string>
1515

16+
#include <React/Utils.h>
1617
#include <react/renderer/debug/DebugStringConvertible.h>
1718
#include <react/renderer/debug/DebugStringConvertibleItem.h>
18-
#include <react/utils/FloatComparison.h>
1919

2020
namespace facebook::react {
2121

packages/react-native/ReactCommon/react/renderer/debug/flags.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#include <react/cxxstableapi/UmbrellaGuard.h>
1111

12-
#include <react/debug/flags.h>
12+
#include <React/Debug.h>
1313

1414
//
1515
// This file contains flags that should __never__ be enabled for

0 commit comments

Comments
 (0)