Commit bdf6db8
authored
feat(generators): widen DepartmentNameGenerator data, fix de/en mismatch (#192)
## Summary
- Reported as a missing generator (\`DepartmentNameGenerator\`), but it
already exists at
\`datamimic_ce/domains/common/literal_generators/department_name_generator.py\`
- registered automatically via \`auto_register_generators()\` (location
+ naming convention, no manual export needed).
- The actual gap: a thin word list (no Engineering/Finance/Customer
Support/Operations/R&D) and a de/en mismatch - the German list carried
untranslated English words ("Accounting") and was missing a
"Manufacturing" counterpart.
- Widened both locale lists to the same 13 departments, properly
translated for de.
- Added the missing unit test (none existed - only incidental DSL
coverage in \`test_large_count/test_generators.xml\` and the demo
\`organization.xml\` that exercises generation without asserting on
values).
## Test plan
- [x] New unit test (\`test_department_name_generator_support_locale\`,
\`test_department_name_generator_unsupported_locale_falls_back_to_en\`).
- [x] Existing DSL fixture using the generator still passes.
- [x] mypy/ruff clean.1 parent aedb97e commit bdf6db8
2 files changed
Lines changed: 32 additions & 1 deletion
File tree
- datamimic_ce/domains/common/literal_generators
- tests_ce/unit_tests/test_generator
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
29 | | - | |
| 34 | + | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
33 | 38 | | |
| 39 | + | |
34 | 40 | | |
35 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
36 | 47 | | |
37 | 48 | | |
38 | 49 | | |
| |||
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
0 commit comments