Skip to content

SC2034: dead variable assignments in devkit_proxmox.STDIN.normalize and proxmox_vm.vm_id.get_usage #117

Description

@t0kubetsu

Problem

Two scripts have variables that are assigned but never read, triggering ShellCheck SC2034 warnings.

devkit_proxmox.STDIN.normalize.to.jsons.sh

SIMPLE_VALUE and SIMPLE_TYPE are declared as locals and assigned inside an if/elif block, but neither is ever referenced afterwards. The function re-checks STDIN_DATA directly via regex at the actual usage sites.

proxmox_vm.vm_id.get_usage.to.jsons.sh

DEFAULT_OUTPUT_JSON is a TODO placeholder that was never wired up. OUTPUT_JSON is derived from it and written by the --json/--text flag parser, but is never read downstream — the output mode switching was planned but not implemented.

Expected behaviour

Both scripts pass shellcheck --severity=warning with no SC2034 violations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions