wip on maximize

Author: thedavidmeister

src/lib/implementation/LibDecimalFloatImplementation.sol

@@ -11,6 +11,8 @@ import {
 } from "../../generated/LogTables.pointers.sol";
 import {LibDecimalFloat} from "../LibDecimalFloat.sol";
 
+import {console2} from "forge-std/console2.sol";
+
 error WithTargetExponentOverflow(int256 signedCoefficient, int256 exponent, int256 targetExponent);
 
 uint256 constant ADD_MAX_EXPONENT_DIFF = 76;
@@ -560,21 +562,7 @@ library LibDecimalFloatImplementation {
             // know until we try. This pushes us into [1e76,type(int256).max] and
             // [-type(int256).max,-1e76] ranges, if that's possible.
             int256 trySignedCoefficient = signedCoefficient * 10;
-
-            // Checking for overflow without branching logic.
-            bool notOverflow;
-            assembly ("memory-safe") {
-                // Sign is same if the high bits are both 0 or both 1.
-                let signSame := iszero(shr(0xff, xor(trySignedCoefficient, signedCoefficient)))
-                // If the sign is the same, then the new value is larger if
-                // dividing it by the old value is non-zero.
-                let bigger := iszero(iszero(sdiv(trySignedCoefficient, signedCoefficient)))
-
-                // We didn't overflow if the sign is the same and the new value
-                // is larger than the old value.
-                notOverflow := and(signSame, bigger)
-            }
-            if (notOverflow) {
+            if (signedCoefficient == trySignedCoefficient / 10) {
                 signedCoefficient = trySignedCoefficient;
                 exponent -= 1;
             }

test/src/lib/implementation/LibDecimalFloatImplementation.log10.t.sol

@@ -31,19 +31,19 @@ contract LibDecimalFloatImplementationLog10Test is LogTest {
     }
 
     function testExactLookupsLog10() external {
-        checkLog10(1001, 0, 3.0004e75, -75);
-        checkLog10(100.1e1, -1, 2.0004e75, -75);
-        checkLog10(10.01e2, -2, 1.0004e75, -75);
+        checkLog10(1001, 0, 3.0004e76, -76);
+        checkLog10(100.1e1, -1, 2.0004e76, -76);
+        checkLog10(10.01e2, -2, 1.0004e76, -76);
         checkLog10(1.001e3, -3, 0.0004e38, -38);
 
-        checkLog10(10.02e2, -2, 1.0009e75, -75);
-        checkLog10(10.99e2, -2, 1.0411e75, -75);
+        checkLog10(10.02e2, -2, 1.0009e76, -76);
+        checkLog10(10.99e2, -2, 1.0411e76, -76);
 
-        checkLog10(6566, 0, 3.8173e75, -75);
+        checkLog10(6566, 0, 3.8173e76, -76);
     }
 
     function testInterpolatedLookups() external {
-        checkLog10(10.015e3, -3, 1.00065e75, -75);
+        checkLog10(10.015e3, -3, 1.00065e76, -76);
     }
 
     function testSub1() external {