Merge pull request #944 from rabbitmq/void-promise

acogoluegnes · web-flow · commit 445a15085ef7 · 2026-02-27T16:06:38.000+01:00
Add voidPromise to channel write when possible
diff --git a/src/main/java/com/rabbitmq/stream/impl/Client.java b/src/main/java/com/rabbitmq/stream/impl/Client.java
@@ -1309,7 +1309,7 @@ public void credit(byte subscriptionId, int credit) {
     bb.writeShort(VERSION_1);
     bb.writeByte(subscriptionId);
     bb.writeShort((short) credit);
-    channel.writeAndFlush(bb);
+    channel.writeAndFlush(bb, channel.voidPromise());
   }
 
   /**
@@ -1418,7 +1418,7 @@ public void storeOffset(String reference, String stream, long offset) {
     bb.writeShort(stream.length());
     bb.writeBytes(stream.getBytes(CHARSET));
     bb.writeLong(offset);
-    channel.writeAndFlush(bb);
+    channel.writeAndFlush(bb, channel.voidPromise());
   }
 
   public QueryOffsetResponse queryOffset(String reference, String stream) {
@@ -1890,7 +1890,7 @@ public void consumerUpdateResponse(
     if (offsetSpecification.isOffset() || offsetSpecification.isTimestamp()) {
       bb.writeLong(offsetSpecification.getOffset());
     }
-    channel.writeAndFlush(bb);
+    channel.writeAndFlush(bb, channel.voidPromise());
   }
 
   void shutdownReason(ShutdownReason reason) {

Original file line number	Diff line number	Diff line change
`@@ -1309,7 +1309,7 @@ public void credit(byte subscriptionId, int credit) {`
`1309`	`1309`	`bb.writeShort(VERSION_1);`
`1310`	`1310`	`bb.writeByte(subscriptionId);`
`1311`	`1311`	`bb.writeShort((short) credit);`
`1312`		`- channel.writeAndFlush(bb);`
	`1312`	`+ channel.writeAndFlush(bb, channel.voidPromise());`
`1313`	`1313`	`}`
`1314`	`1314`
`1315`	`1315`	`/**`
`@@ -1418,7 +1418,7 @@ public void storeOffset(String reference, String stream, long offset) {`
`1418`	`1418`	`bb.writeShort(stream.length());`
`1419`	`1419`	`bb.writeBytes(stream.getBytes(CHARSET));`
`1420`	`1420`	`bb.writeLong(offset);`
`1421`		`- channel.writeAndFlush(bb);`
	`1421`	`+ channel.writeAndFlush(bb, channel.voidPromise());`
`1422`	`1422`	`}`
`1423`	`1423`
`1424`	`1424`	`public QueryOffsetResponse queryOffset(String reference, String stream) {`
`@@ -1890,7 +1890,7 @@ public void consumerUpdateResponse(`
`1890`	`1890`	`if (offsetSpecification.isOffset() \|\| offsetSpecification.isTimestamp()) {`
`1891`	`1891`	`bb.writeLong(offsetSpecification.getOffset());`
`1892`	`1892`	`}`
`1893`		`- channel.writeAndFlush(bb);`
	`1893`	`+ channel.writeAndFlush(bb, channel.voidPromise());`
`1894`	`1894`	`}`
`1895`	`1895`
`1896`	`1896`	`void shutdownReason(ShutdownReason reason) {`