Skip to content

Commit e0e56ed

Browse files
EddyLXJmeta-codesync[bot]
authored andcommitted
Move internal enrichment files to fb/ for OSS exclusion (#5541)
Summary: Pull Request resolved: #5541 X-link: https://github.com/facebookresearch/FBGEMM/pull/2508 CONTEXT: Several enrichment files in dram_kv_embedding_cache depend on internal Meta APIs (opentab, maple, laser, servicerouter, feature_store) but were being synced to the public pytorch/FBGEMM GitHub repo. This forces anyone changing these internal APIs to go through the GitHub sync process unnecessarily, since these files are dead code in OSS. WHAT: Move 6 internal-only enrichment files from src/dram_kv_embedding_cache/ to fb/src/dram_kv_embedding_cache/ so they are excluded from OSS sync. Update all #include paths and BUCK target references accordingly. Files moved: - oneflow_enrichment.cpp (depends on opentab/maple) - oneflow_enrichment.h - opentab_backend_registry.h - feature_store_enrichment.cpp (depends on servicerouter/feature_store) - feature_store_enrichment.h - igr_enrichment.h (depends on laser) Reviewed By: emlin Differential Revision: D98357970 fbshipit-source-id: 0426f86bc98bd9ba3d41f5e81736aa43691a3eed
1 parent 642784f commit e0e56ed

7 files changed

Lines changed: 3 additions & 1126 deletions

File tree

fbgemm_gpu/src/dram_kv_embedding_cache/dram_kv_embedding_cache.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
#include "../ssd_split_embeddings_cache/initializer.h"
3131
#include "../ssd_split_embeddings_cache/kv_db_table_batched_embeddings.h"
3232
#include "SynchronizedShardedMap.h"
33+
#include "deeplearning/fbgemm/fbgemm_gpu/fb/src/dram_kv_embedding_cache/feature_store_enrichment.h"
34+
#include "deeplearning/fbgemm/fbgemm_gpu/fb/src/dram_kv_embedding_cache/igr_enrichment.h"
35+
#include "deeplearning/fbgemm/fbgemm_gpu/fb/src/dram_kv_embedding_cache/oneflow_enrichment.h"
3336
#include "enrichment_config.h"
3437
#include "fbgemm_gpu/split_embeddings_cache/kv_db_cpp_utils.h"
3538
#include "feature_evict.h"
36-
#include "feature_store_enrichment.h"
3739
#include "fixed_block_pool.h"
38-
#include "igr_enrichment.h"
39-
#include "oneflow_enrichment.h"
4040

4141
namespace kv_mem {
4242

fbgemm_gpu/src/dram_kv_embedding_cache/feature_store_enrichment.cpp

Lines changed: 0 additions & 174 deletions
This file was deleted.

fbgemm_gpu/src/dram_kv_embedding_cache/feature_store_enrichment.h

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)