Skip to content

Commit 1fed740

Browse files
Lizhe Jimeta-codesync[bot]
authored andcommitted
Add metadata_dim_ and total_rows_written_ members to EmbeddingRocksDB (#5883)
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/2802 Pull Request resolved: #5883 Declare two new EmbeddingRocksDB member fields used by the metadata column family feature later in the stack: - metadata_dim_: width of the metaheader stored in the separate metadata CF - total_rows_written_: cumulative count of rows written Reviewed By: EddyLXJ Differential Revision: D108342270 fbshipit-source-id: 00587c00d698897dd46396ec3abac75c56291d0a
1 parent 8866322 commit 1fed740

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

fbgemm_gpu/src/ssd_split_embeddings_cache/ssd_table_batched_embeddings.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,10 +1396,12 @@ class EmbeddingRocksDB : public kv_db::EmbeddingKVDB {
13961396
std::atomic<int64_t> fwd_l1_eviction_dur_{0};
13971397
std::atomic<int64_t> bwd_l1_cnflct_miss_write_back_dur_{0};
13981398
std::atomic<int64_t> flush_write_dur_{0};
1399+
std::atomic<int64_t> total_rows_written_{0}; // cumulative actual rows written
13991400

14001401
std::unordered_map<const SnapshotHandle*, std::unique_ptr<SnapshotHandle>>
14011402
snapshots_;
14021403
int64_t max_D_;
1404+
int64_t metadata_dim_;
14031405
int64_t elem_size_;
14041406
std::vector<int64_t> sub_table_dims_;
14051407
std::vector<int64_t> sub_table_hash_cumsum_;

0 commit comments

Comments
 (0)