fix(cli): harden sea release assets

Author: altaywtf

package.json

@@ -34,7 +34,7 @@
     "check": "vp check .",
     "coverage": "vp test --coverage",
     "dev": "vp pack --watch",
-    "prepare": "./scripts/prepare-effect.sh",
+    "prepare": "node ./scripts/prepare-effect.mts",
     "prepack": "vp pack",
     "smoke:pack": "node ./scripts/smoke-packed-install.mts",
     "test": "vp test",

scripts/prepare-effect.mts

@@ -0,0 +1,16 @@
+import { execFileSync } from "node:child_process";
+import { existsSync, mkdirSync } from "node:fs";
+
+if (process.env.CI || process.env.GITHUB_ACTIONS) {
+  process.exit(0);
+}
+
+const repoDir = ".repos/effect";
+const repoUrl = "https://github.com/Effect-TS/effect-smol";
+
+if (existsSync(`${repoDir}/.git`)) {
+  process.exit(0);
+}
+
+mkdirSync(".repos", { recursive: true });
+execFileSync("git", ["clone", repoUrl, repoDir], { stdio: "inherit" });

src/cli.test.ts

@@ -123,6 +123,17 @@ describe("cli argv parsing", () => {
     expect(stdout).toBe(`putio v${packageJson.version}`);
   });
 
+  it("accepts SEA argv that repeats the CLI binary path", async () => {
+    const { result, stdout } = await runProcessArgv([
+      "/opt/putio/bin/putio",
+      "/opt/putio/bin/putio",
+      "--version",
+    ]);
+
+    expect(result._tag).toBe("Success");
+    expect(stdout).toBe(`putio v${packageJson.version}`);
+  });
+
   it("renders describe as machine-readable json", async () => {
     const { result, stdout } = await runCli(["putio", "describe"]);
 

src/cli.ts

@@ -101,24 +101,36 @@ const executableName = (value: string) => {
   return normalized.slice(normalized.lastIndexOf("/") + 1).toLowerCase();
 };
 
+const isNodeExecutable = (value: string) => {
+  const name = executableName(value);
+  return name === "node" || name === "node.exe";
+};
+
+const isPutioExecutable = (value: string) => {
+  const name = executableName(value);
+  return name === "putio" || name === "putio.exe" || name === "bin.mjs";
+};
+
+const stripLeadingPutioExecutables = (args: ReadonlyArray<string>) => {
+  let start = 0;
+  while (isPutioExecutable(args[start] ?? "")) {
+    start++;
+  }
+  return args.slice(start);
+};
+
 const commandArgsFromArgv = (args: ReadonlyArray<string>) => {
   const [first] = args;
 
   if (first === undefined) {
     return args;
   }
 
-  const firstName = executableName(first);
-
-  if (firstName === "node" || firstName === "node.exe") {
-    return args.slice(2);
-  }
-
-  if (firstName === "putio" || firstName === "putio.exe" || firstName === "bin.mjs") {
-    return args.slice(1);
+  if (isNodeExecutable(first)) {
+    return stripLeadingPutioExecutables(args.slice(2));
   }
 
-  return args;
+  return stripLeadingPutioExecutables(args);
 };
 
 type CliCommandEnvironment =