Null path in validator.js

[jonathankoren]

Thanks in advance for your bug report!

• Have you reproduced issue in safe mode?
• Have you used the debugging guide to try to resolve the issue?
• Have you checked our FAQs to make sure your question isn't answered there?
• Have you checked to make sure your issue does not already exist?
• Have you checked you are on the latest release of Pulsar?

What happened?

After opening a file in a git repo that has a conflict, the UI becomes sluggish, and errors about a null path in validator.js continuously appears.

the UI should have remained performant regardless of configuration or any other unexpected data

Pulsar version

1.121.0 arm64

Which OS does this happen on?

🍎 macOS

OS details

15.0

Which CPU architecture are you running this on?

Apple M-series

What steps are needed to reproduce this?

Open inside a git repo that has a merge confilict

Expected behavior:

the UI remain responsive

Actual behavior:

Pulsar becomes very laggy and errors about null paths in validator.js continuously show up

Additional Information:

Versions

Pulsar: 1.121.0 arm64
Electron: 12.2.3
OS: macOS 15.0
Thrown From: github package 0.36.20

Stack Trace

Uncaught TypeError: The "path" argument must be of type string. Received null

At internal/validators.js:124

TypeError [ERR_INVALID_ARG_TYPE] [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null
    at validateString (internal/validators.js:124:11)
    at Object.join (path.js:1039:7)
    at /app.asar/node_modules/github/lib/controllers/repository-conflict-controller.js:74:106
    at Array.map (<anonymous>)
    at RepositoryConflictController.getConflictingEditors (/app.asar/node_modules/github/lib/controllers/repository-conflict-controller.js:74:72)
    at RepositoryConflictController.renderWithData (/app.asar/node_modules/github/lib/controllers/repository-conflict-controller.js:59:37)
    at Object.children (/app.asar/node_modules/github/lib/controllers/repository-conflict-controller.js:56:21)
    at ObserveModel.render (/app.asar/node_modules/github/lib/views/observe-model.js:45:23)
    at finishClassComponent (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:18470:31)
    at updateClassComponent (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:18423:24)
    at /app.asar/node_modules/react-dom/cjs/react-dom.development.js:20186:16)
    at HTMLUnknownElement.callCallback (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at Object.invokeGuardedCallbackDev (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at /app.asar/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at /app.asar/node_modules/react-dom/cjs/react-dom.development.js:12199:24
    at unstable_runWithPriority (/app.asar/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at /app.asar/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushSyncCallbackQueueImpl (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:12194:7)
    at flushSyncCallbackQueue (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:12182:3)
    at scheduleUpdateOnFiber (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:23709:9)
    at updateContainer (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:27103:3)
    at legacyRenderSubtreeIntoContainer (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:27544:5)
    at Object.render (/app.asar/node_modules/react-dom/cjs/react-dom.development.js:27608:10)
    at GithubPackage.renderFn (/app.asar/node_modules/github/lib/github-package.js:143:32)
    at GithubPackage.rerender (/app.asar/node_modules/github/lib/github-package.js:298:10)
    at GithubPackage.setActiveContext (/app.asar/node_modules/github/lib/github-package.js:636:12)

Commands

     -1:31.5.0 find-and-replace:show (input.hidden-input)
     -1:31.5.0 find-and-replace:find-next (input.hidden-input)
     -1:30.4.0 find-and-replace:show (input.hidden-input)
     -1:27.7.0 editor:consolidate-selections (input.hidden-input)
     -1:27.7.0 core:cancel (input.hidden-input)
     -1:26 application:new-file (input.hidden-input)
     -1:25.7.0 core:move-right (input.hidden-input)
     -1:23.9.0 pane:split-right-and-copy-active-item (input.hidden-input)
     -0:56.6.0 pulsar-updater:check-for-update (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
  2x -0:50.9.0 core:close (button.btn.about-update-action-button)
     -0:47.1.0 core:move-down (input.hidden-input)
  2x -0:46.1.0 editor:move-to-first-character-of-line (input.hidden-input)
  3x -0:43.9.0 core:select-down (input.hidden-input)
     -0:42.7.0 core:cut (input.hidden-input)
     -0:40.4.0 core:paste (input.hidden-input)

Non-Core Packages

split-diff 1.6.1