Barnacle crashes on removing a profile that contains mods

[Kruziikrel13]

1. Attempt to delete a profile containing at least one mod.
2. Witness crash

Running with RUST_BACKTRACE=1 I get the below (and a longer backtrace)

thread 'main' panicked at barnacle-gui/src/components/mod_list/mod.rs:125:50:
called `Result::unwrap()` on an `Err` value: RemovedEntity

[Kruziikrel13]

Quietly suppressing it using unwrap_or_default results in a broken UI state.

The mod entry isn't actually removed from the UI.

In addition, toggling the entry still crashes the UI with the same Err.

[Kruziikrel13]

In addition, the mods don't get removed from mods directory. And they are permission protected and as such I can't delete them using normal permissions (i.e. rm -rf)

[poperigby]

The first part makes sense, because the mod list isn't notified that the profile it's referring to has been deleted, so all the mods it's showing will be stale entities.

The reason the mods don't get removed is because mods aren't tied to profiles, mod entries are. Mod entries are special records that live under profiles, and point to mods. Games are what own mods. If you delete a game, it will delete all the mods.

[poperigby]

I've added a CONTRIBUTING.md to barnacle-lib that explains the schema: https://github.com/poperigby/barnacle/blob/trunk/barnacle-lib/CONTRIBUTING.md

[Kruziikrel13]

Ah yep, I later deduced mods would stick around as they aren't profile specific but neglected to update here. That's a cool doc!