Skip to content

Commit a172d21

Browse files
authored
[Metrics] Fix missing endpoint_domain when the observation has an error (#441)
<img width="918" height="734" alt="Screenshot 2025-09-08 at 5 24 37 PM" src="https://github.com/user-attachments/assets/efd557ff-2af5-4dd5-9536-955abe415339" />
1 parent 9861677 commit a172d21

1 file changed

Lines changed: 12 additions & 9 deletions

File tree

metrics/protocol/shannon/metrics.go

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,8 @@ func recordRelayTotal(
446446
"error_type": requestErrorType,
447447
// Relay request failed before reaching out to any endpoints so no fallback was used.
448448
// Must be set to avoid inconsistent label cardinality error
449-
"used_fallback": "false",
449+
"used_fallback": "false",
450+
"endpoint_domain": ErrDomain,
450451
},
451452
).Inc()
452453

@@ -785,10 +786,11 @@ func recordWebsocketConnectionTotal(
785786
if requestHasErr, requestErrorType := extractRequestError(observations); requestHasErr {
786787
websocketConnectionsTotal.With(
787788
prometheus.Labels{
788-
"service_id": serviceID,
789-
"success": "false",
790-
"error_type": requestErrorType,
791-
"used_fallback": "false",
789+
"service_id": serviceID,
790+
"success": "false",
791+
"error_type": requestErrorType,
792+
"used_fallback": "false",
793+
"endpoint_domain": ErrDomain,
792794
},
793795
).Inc()
794796
return
@@ -837,10 +839,11 @@ func recordWebsocketMessageTotal(
837839
if requestHasErr, requestErrorType := extractRequestError(observations); requestHasErr {
838840
websocketMessagesTotal.With(
839841
prometheus.Labels{
840-
"service_id": serviceID,
841-
"success": "false",
842-
"error_type": requestErrorType,
843-
"used_fallback": "false",
842+
"service_id": serviceID,
843+
"success": "false",
844+
"error_type": requestErrorType,
845+
"used_fallback": "false",
846+
"endpoint_domain": ErrDomain,
844847
},
845848
).Inc()
846849
return

0 commit comments

Comments
 (0)