Skip to content

Commit d2e8c3b

Browse files
committed
resource-directory: allow drop event when buffer of subscription is exhausted
1 parent 0f6a280 commit d2e8c3b

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

resource-directory/service/subscriptions.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ func (s *subscriptions) SubscribeForEvents(resourceProjection *Projection, srv p
682682
}
683683
}()
684684

685-
sendChan := make(chan pb.Event, 16)
685+
sendChan := make(chan pb.Event, 1024)
686686
go func() {
687687
defer wg.Done()
688688
for {
@@ -705,9 +705,11 @@ func (s *subscriptions) SubscribeForEvents(resourceProjection *Projection, srv p
705705
case sendChan <- e:
706706
return nil
707707
case <-ctx.Done():
708-
return fmt.Errorf("cannot send event: stream context returns error: %v", ctx.Err())
708+
return fmt.Errorf("cannot send event (%+v) for subscription(%v): stream context returns error: %v", e.GetType(), e.GetSubscriptionId(), ctx.Err())
709709
case <-senderCtx.Done():
710-
return fmt.Errorf("cannot send event: sender context returns error: %v", ctx.Err())
710+
return fmt.Errorf("cannot send event (%+v) for subscription(%v): sender context returns error: %v", e.GetType(), e.GetSubscriptionId(), ctx.Err())
711+
default:
712+
return fmt.Errorf("cannot send event (%+v) for subscription(%v): buffer it exhausted", e.GetType(), e.GetSubscriptionId())
711713
}
712714
}
713715

0 commit comments

Comments
 (0)