Print error log into log file instead of terminal (#1355) (#1358)

ti-chi-bot · web-flow · commit 1b7c88b93909 · 2021-07-23T17:04:14.000+08:00
diff --git a/pkg/restore/systable_restore.go b/pkg/restore/systable_restore.go
@@ -91,7 +91,7 @@ func (rc *Client) RestoreSystemSchemas(ctx context.Context, f filter.Filter) {
 		tableName := table.Info.Name
 		if f.MatchTable(sysDB, tableName.O) {
 			if err := rc.replaceTemporaryTableToSystable(ctx, tableName.L, db); err != nil {
-				logutil.WarnTerm("error during merging temporary tables into system tables",
+				log.Warn("error during merging temporary tables into system tables",
 					logutil.ShortError(err),
 					zap.Stringer("table", tableName),
 				)
@@ -101,7 +101,7 @@ func (rc *Client) RestoreSystemSchemas(ctx context.Context, f filter.Filter) {
 	}
 	if err := rc.afterSystemTablesReplaced(ctx, tablesRestored); err != nil {
 		for _, e := range multierr.Errors(err) {
-			logutil.WarnTerm("error during reconfigurating the system tables", zap.String("database", sysDB), logutil.ShortError(e))
+			log.Warn("error during reconfigurating the system tables", zap.String("database", sysDB), logutil.ShortError(e))
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func (rc *Client) RestoreSystemSchemas(ctx context.Context, f filter.Filter) {`
`91`	`91`	`tableName := table.Info.Name`
`92`	`92`	`if f.MatchTable(sysDB, tableName.O) {`
`93`	`93`	`if err := rc.replaceTemporaryTableToSystable(ctx, tableName.L, db); err != nil {`
`94`		`- logutil.WarnTerm("error during merging temporary tables into system tables",`
	`94`	`+ log.Warn("error during merging temporary tables into system tables",`
`95`	`95`	`logutil.ShortError(err),`
`96`	`96`	`zap.Stringer("table", tableName),`
`97`	`97`	`)`
`@@ -101,7 +101,7 @@ func (rc *Client) RestoreSystemSchemas(ctx context.Context, f filter.Filter) {`
`101`	`101`	`}`
`102`	`102`	`if err := rc.afterSystemTablesReplaced(ctx, tablesRestored); err != nil {`
`103`	`103`	`for _, e := range multierr.Errors(err) {`
`104`		`- logutil.WarnTerm("error during reconfigurating the system tables", zap.String("database", sysDB), logutil.ShortError(e))`
	`104`	`+ log.Warn("error during reconfigurating the system tables", zap.String("database", sysDB), logutil.ShortError(e))`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`	`}`