use extension

Author: staabm

extension.neon

@@ -29,7 +29,6 @@ parameters:
 		- stubs/Utils/Html.stub
 		- stubs/Utils/Paginator.stub
 		- stubs/Utils/Random.stub
-		- stubs/Utils/Strings.stub
 	universalObjectCratesClasses:
 		- Nette\Application\UI\ITemplate
 		- Nette\Application\UI\Template
@@ -138,3 +137,13 @@ services:
 		class: PHPStan\Type\Nette\StringsReplaceCallbackClosureTypeExtension
 		tags:
 			- phpstan.staticMethodParameterClosureTypeExtension
+
+	-
+		class: PHPStan\Type\Nette\StringsLengthTypeSpecifiyingExtension
+		tags:
+			- phpstan.typeSpecifier.staticMethodTypeSpecifyingExtension
+
+	-
+		class: PHPStan\Type\Nette\StringsLengthDynamicReturnTypeExtension
+		tags:
+			- phpstan.broker.dynamicStaticMethodReturnTypeExtension

src/Type/Nette/StringsLengthDynamicReturnTypeExtension.php

@@ -0,0 +1,54 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Nette;
+
+use Nette\Utils\Strings;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Analyser\SpecifiedTypes;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\TrinaryLogic;
+use PHPStan\Type\Constant\ConstantBooleanType;
+use PHPStan\Type\Constant\ConstantIntegerType;
+use PHPStan\Type\DynamicStaticMethodReturnTypeExtension;
+use PHPStan\Type\IntegerRangeType;
+use PHPStan\Type\NullType;
+use PHPStan\Type\Php\RegexArrayShapeMatcher;
+use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
+use function array_key_exists;
+use const PREG_OFFSET_CAPTURE;
+use const PREG_UNMATCHED_AS_NULL;
+
+class StringsLengthDynamicReturnTypeExtension implements DynamicStaticMethodReturnTypeExtension
+{
+
+	public function getClass(): string
+	{
+		return Strings::class;
+	}
+
+	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === 'length';
+	}
+
+	public function getTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
+	{
+		$args = $methodCall->getArgs();
+		$stringArg = $args[0] ?? null;
+
+		if ($stringArg === null) {
+			return new SpecifiedTypes();
+		}
+
+		$type = $scope->getType($stringArg->value);
+		if ($type->isNonEmptyString()->yes()) {
+			return IntegerRangeType::fromInterval(1, null);
+		}
+
+		return null;
+	}
+
+}

src/Type/Nette/StringsLengthTypeSpecifiyingExtension.php

@@ -0,0 +1,60 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Nette;
+
+use Nette\Utils\Strings;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Analyser\SpecifiedTypes;
+use PHPStan\Analyser\TypeSpecifier;
+use PHPStan\Analyser\TypeSpecifierAwareExtension;
+use PHPStan\Analyser\TypeSpecifierContext;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\Accessory\AccessoryNonEmptyStringType;
+use PHPStan\Type\IntersectionType;
+use PHPStan\Type\StaticMethodTypeSpecifyingExtension;
+use PHPStan\Type\StringType;
+
+class StringsLengthTypeSpecifiyingExtension implements StaticMethodTypeSpecifyingExtension, TypeSpecifierAwareExtension
+{
+
+	private TypeSpecifier $typeSpecifier;
+
+	public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void
+	{
+		$this->typeSpecifier = $typeSpecifier;
+	}
+
+	public function getClass(): string
+	{
+		return Strings::class;
+	}
+
+	public function isStaticMethodSupported(MethodReflection $staticMethodReflection, StaticCall $node, TypeSpecifierContext $context): bool
+	{
+		return $context->true() && $staticMethodReflection->getName() === 'length';
+	}
+
+	public function specifyTypes(MethodReflection $staticMethodReflection, StaticCall $node, Scope $scope, TypeSpecifierContext $context): SpecifiedTypes
+	{
+		$args = $node->getArgs();
+		$stringArg = $args[0] ?? null;
+
+		if ($stringArg === null) {
+			return new SpecifiedTypes();
+		}
+
+		$type = $scope->getType($stringArg->value);
+		if (!$type->isString()->yes()) {
+			return new SpecifiedTypes();
+		}
+
+		return $this->typeSpecifier->create(
+			$stringArg->value,
+			new IntersectionType([new StringType(), new AccessoryNonEmptyStringType()]),
+			$context,
+			$scope,
+		);
+	}
+
+}

tests/Type/Nette/data/strings.php strings.phptests/Type/Nette/data/strings.php renamed to strings.php

@@ -27,7 +27,7 @@ public function dataFileAsserts(): iterable
 			yield from self::gatherAssertTypes(__DIR__ . '/data/multiplier.php');
 		}
 
-		yield from $this->gatherAssertTypes(__DIR__ . '/data/strings.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/strings-length.php');
 	}
 
 	/**

stubs/Utils/Strings.stub

@@ -0,0 +1,24 @@
+<?php
+
+namespace StringsTypesNarrowing;
+
+use Nette\Utils\Strings;
+use function PHPStan\Testing\assertType;
+
+function doFoo(string $string) {
+	assertType('string', $string);
+	if (Strings::length($string)) {
+		assertType('non-empty-string', $string);
+		assertType('int<1, max>', Strings::length($string));
+	} else {
+		assertType('string', $string);
+		assertType('0', Strings::length($string));
+	}
+	assertType('string', $string);
+	assertType('int', Strings::length($string));
+
+	if (Strings::length($string) === 0) {
+		assertType('string', $string);
+	}
+	assertType('string', $string);
+}