try fix ic test

Author: puneet2019

interchaintest/chain_upgrade_test.go

@@ -81,7 +81,7 @@ func CosmosChainUpgradeTest(
 		}},
 		CoinDecimals:   &helpers.PersistenceCoinDecimals,
 		GasPrices:      fmt.Sprintf("0%s", helpers.PersistenceBondDenom),
-		EncodingConfig: persistenceEncoding(),
+		EncodingConfig: PersistenceEncoding(),
 		ModifyGenesis:  cosmos.ModifyGenesis(defaultGenesisOverridesKV),
 	}
 

interchaintest/helpers/staking.go

@@ -19,7 +19,7 @@ func QueryAllValidators(t *testing.T, ctx context.Context, chainNode *cosmos.Cha
 	debugOutput(t, string(stdout))
 
 	var resp queryValidatorsResponse
-	err = json.Unmarshal([]byte(stdout), &resp)
+	err = json.Unmarshal(stdout, &resp)
 	require.NoError(t, err)
 
 	return resp.Validators
@@ -38,7 +38,7 @@ func QueryValidator(
 	debugOutput(t, string(stdout))
 
 	var validator Validator
-	err = json.Unmarshal([]byte(stdout), &validator)
+	err = json.Unmarshal(stdout, &validator)
 	require.NoError(t, err)
 
 	return validator
@@ -58,7 +58,7 @@ func QueryDelegation(
 	debugOutput(t, string(stdout))
 
 	var resp queryDelegationResponse
-	err = json.Unmarshal([]byte(stdout), &resp)
+	err = json.Unmarshal(stdout, &resp)
 	require.NoError(t, err)
 
 	return resp.Delegation
@@ -77,7 +77,7 @@ func QueryUnbondingDelegations(
 	debugOutput(t, string(stdout))
 
 	var resp queryUnbondingDelegationsResponse
-	err = json.Unmarshal([]byte(stdout), &resp)
+	err = json.Unmarshal(stdout, &resp)
 	require.NoError(t, err)
 
 	return resp.UnbondingResponses
@@ -115,7 +115,7 @@ func QueryTotalLiquidStaked(
 	debugOutput(t, string(stdout))
 
 	var resp queryTotalLiquidStaked
-	err = json.Unmarshal([]byte(stdout), &resp)
+	err = json.Unmarshal(stdout, &resp)
 	require.NoError(t, err)
 
 	return resp.Tokens

interchaintest/liquidstake_stkxprt_globalcap_test.go

@@ -142,6 +142,11 @@ func TestLiquidStakeGlobalCapStkXPRT(t *testing.T) {
 	proposalID, err := strconv.ParseUint(upgradeTx.ProposalID, 10, 64)
 	require.NoError(t, err, "error parsing proposal id")
 
+	proposal, err := chain.GovQueryProposalV1(ctx, proposalID)
+	require.NoError(t, err, "error getting proposal")
+	t.Log(proposal)
+	require.Equal(t, govv1.StatusVotingPeriod, proposal.Status)
+
 	err = chain.VoteOnProposalAllValidators(ctx, proposalID, cosmos.ProposalVoteYes)
 	require.NoError(t, err, "failed to submit votes")
 

interchaintest/liquidstake_stkxprt_test.go

@@ -136,8 +136,8 @@ func TestLiquidStakeStkXPRT(t *testing.T) {
 
 	proposal, err := chain.GovQueryProposalV1(ctx, proposalID)
 	require.NoError(t, err, "error getting proposal")
-	require.Equal(t, govv1.StatusVotingPeriod, proposal.Status)
 	t.Log(proposal)
+	require.Equal(t, govv1.StatusVotingPeriod, proposal.Status, "proposal status equal check")
 
 	err = chain.VoteOnProposalAllValidators(ctx, proposalID, cosmos.ProposalVoteYes)
 	require.NoError(t, err, "failed to submit votes")

interchaintest/lsm_bond_tokenize_test.go

@@ -59,8 +59,13 @@ func TestBondTokenize(t *testing.T) {
 		"staking", "delegate", validators[0].OperatorAddress, firstUserDelegationCoins.String(),
 		"--gas=auto",
 	)
+
 	require.NoError(t, err)
 
+	delegation := helpers.QueryDelegation(t, ctx, chainNode, firstUser.FormattedAddress(), validators[0].OperatorAddress)
+	require.Equal(t, math.LegacyNewDecFromInt(firstUserDelegationCoins.Amount), delegation.Shares, "compare first user delegated amounts to delegation.shares")
+	require.False(t, delegation.ValidatorBond)
+
 	// Delegate from second user
 	secondUserDelegationAmount := math.NewInt(1_000_000)
 	secondUserDelegationCoins := sdk.NewCoin(testDenom, secondUserDelegationAmount)
@@ -70,11 +75,11 @@ func TestBondTokenize(t *testing.T) {
 	)
 	require.NoError(t, err)
 
-	delegation := helpers.QueryDelegation(t, ctx, chainNode, secondUser.FormattedAddress(), validators[0].OperatorAddress)
-	require.Equal(t, math.LegacyNewDecFromInt(secondUserDelegationCoins.Amount), delegation.Shares)
+	delegation = helpers.QueryDelegation(t, ctx, chainNode, secondUser.FormattedAddress(), validators[0].OperatorAddress)
+	require.Equal(t, math.LegacyNewDecFromInt(secondUserDelegationCoins.Amount), delegation.Shares, "compare second user delegated amounts to delegation.shares")
 	require.False(t, delegation.ValidatorBond)
 
-	// Try to tokenize shares from first user, it won't work because there is no minimal bond
+	// Try to tokenize shares from the first user, it won't work because there is no minimal bond
 	tokenizeCoins := sdk.NewCoin(testDenom, math.NewInt(250_000_000))
 	txHash, err := chainNode.ExecTx(ctx, firstUser.KeyName(),
 		"staking", "tokenize-share", validators[0].OperatorAddress, tokenizeCoins.String(), firstUser.FormattedAddress(),

interchaintest/lsm_halt_fork_test.go

@@ -51,7 +51,7 @@ func TestPersistenceLSMHaltFork(t *testing.T) {
 		}},
 
 		GasPrices:      fmt.Sprintf("0%s", helpers.PersistenceBondDenom),
-		EncodingConfig: persistenceEncoding(),
+		EncodingConfig: PersistenceEncoding(),
 		ModifyGenesis:  cosmos.ModifyGenesis(defaultGenesisOverridesKV),
 	}
 

interchaintest/module_pfm_test.go

@@ -70,7 +70,7 @@ func TestPacketForwardMiddleware(t *testing.T) {
 		TrustingPeriod:      "112h",
 		NoHostMount:         false,
 		ConfigFileOverrides: nil,
-		EncodingConfig:      persistenceEncoding(),
+		EncodingConfig:      PersistenceEncoding(),
 		ModifyGenesis:       cosmos.ModifyGenesis(defaultGenesisOverridesKV),
 	}
 

interchaintest/setup.go

@@ -86,9 +86,9 @@ var (
 	genesisWalletAmount = math.NewInt(10_000_000)
 )
 
-// persistenceEncoding registers the persistenceCore specific module codecs so that the associated types and msgs
+// PersistenceEncoding registers the persistenceCore specific module codecs so that the associated types and msgs
 // will be supported when writing to the blocksdb sqlite database.
-func persistenceEncoding() *testutil.TestEncodingConfig {
+func PersistenceEncoding() *testutil.TestEncodingConfig {
 	cfg := cosmos.DefaultEncoding()
 
 	// register custom types
@@ -119,7 +119,7 @@ func persistenceChainConfig(
 		TrustingPeriod:      "112h",
 		NoHostMount:         false,
 		ConfigFileOverrides: nil,
-		EncodingConfig:      persistenceEncoding(),
+		EncodingConfig:      PersistenceEncoding(),
 		ModifyGenesis:       cosmos.ModifyGenesis(genesisOverrides),
 
 		Images: []ibc.DockerImage{