Skip to content

Meter EVM gas for asset‐ID conversion and enforce storage_growth in X-Tokens precompiles #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lavish0000 merged 2 commits into from
May 22, 2025
Merged

Meter EVM gas for asset‐ID conversion and enforce storage_growth in X-Tokens precompiles #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29afd17
Refactor asset handling and dispatch calls to use SYSTEM_ACCOUNT_SIZE…
lavish0000 May 22, 2025
226e258
Refactor dispatch calls in xtokens to improve readability by formatti…
lavish0000 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions precompiles/assets-factory/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ where
_handle: &mut impl PrecompileHandle,
id: u64,
) -> EvmResult<Address> {
_handle.record_db_read::<Runtime>(36)?;
Comment thread
sfffaaa marked this conversation as resolved.
let asset_id = id
.try_into()
.map_err(|_| RevertReason::value_is_too_large("asset id type").in_field("id"))?;
Expand Down
42 changes: 36 additions & 6 deletions precompiles/xtokens/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
Comment thread
sfffaaa marked this conversation as resolved.
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down Expand Up @@ -160,7 +165,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down Expand Up @@ -194,7 +204,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down Expand Up @@ -240,7 +255,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down Expand Up @@ -299,7 +319,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down Expand Up @@ -353,7 +378,12 @@ where
dest_weight_limit,
};

RuntimeHelper::<Runtime>::try_dispatch(handle, Some(origin).into(), call, 0)?;
RuntimeHelper::<Runtime>::try_dispatch(
handle,
Some(origin).into(),
call,
SYSTEM_ACCOUNT_SIZE,
)?;

Ok(())
}
Expand Down