fix: add costs for writing to storage and logs#346
Merged
neutrinoks merged 1 commit intoMay 23, 2025
Conversation
talhadaar
approved these changes
May 16, 2025
sfffaaa
approved these changes
May 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing gas cost calculations in the EIP2612 permit method for the balances-erc20 precompile by incorporating storage and log gas cost computations.
- Added gas cost recording for writing to storage via record_cost and record_external_cost.
- Introduced gas cost handling for log calls using record_log_costs_manual.
neutrinoks
force-pushed
the
fix/blk-68-gas-under-metering-in-permit-precompile
branch
2 times, most recently
from
cb2e214 to
0098d1b
Compare
neutrinoks
force-pushed
the
fix/blk-68-gas-under-metering-in-permit-precompile
branch
from
0098d1b to
a09724c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
balances_erc20methodpermitrecord_db_read()method infrontier