Address issue pb33f/wiretap#143

daveshanley · daveshanley · commit f344a1be3b79 · 2026-03-14T20:50:26.000-04:00
scalar rendering now fixed.
diff --git a/renderer/mock_generator.go b/renderer/mock_generator.go
@@ -222,7 +222,9 @@ func (mg *MockGenerator) renderMockJSON(v any) []byte {
 			data, _ = json.Marshal(v)
 		}
 	default:
-		data = []byte(fmt.Sprint(v))
+		// use json.Marshal for scalar types to produce valid JSON
+		// (e.g. strings get properly quoted: "bob" not bob)
+		data, _ = json.Marshal(v)
 	}
 	return data
 }
diff --git a/renderer/mock_generator_test.go b/renderer/mock_generator_test.go
@@ -219,7 +219,7 @@ func TestMockGenerator_GenerateJSONMock_NoExamples_JSON(t *testing.T) {
 	mg := NewMockGenerator(JSON)
 	mock, err := mg.GenerateMock(fake, "")
 	assert.NoError(t, err)
-	assert.Equal(t, "magic-herbs", string(mock))
+	assert.Equal(t, `"magic-herbs"`, string(mock))
 }
 
 func TestMockGenerator_GenerateJSONMock_NoExamples_YAML(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,9 @@ func (mg *MockGenerator) renderMockJSON(v any) []byte {`
`222`	`222`	`data, _ = json.Marshal(v)`
`223`	`223`	`}`
`224`	`224`	`default:`
`225`		`- data = []byte(fmt.Sprint(v))`
	`225`	`+ // use json.Marshal for scalar types to produce valid JSON`
	`226`	`+ // (e.g. strings get properly quoted: "bob" not bob)`
	`227`	`+ data, _ = json.Marshal(v)`
`226`	`228`	`}`
`227`	`229`	`return data`
`228`	`230`	`}`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ func TestMockGenerator_GenerateJSONMock_NoExamples_JSON(t *testing.T) {`
`219`	`219`	`mg := NewMockGenerator(JSON)`
`220`	`220`	`mock, err := mg.GenerateMock(fake, "")`
`221`	`221`	`assert.NoError(t, err)`
`222`		`- assert.Equal(t, "magic-herbs", string(mock))`
	`222`	+ assert.Equal(t, `"magic-herbs"`, string(mock))
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`func TestMockGenerator_GenerateJSONMock_NoExamples_YAML(t *testing.T) {`