14 April 2025: transcode_audio.py is now somewhat more robust

Author: patrick-brian-mooney

HISTORY.md

@@ -445,6 +445,11 @@ Accumulating several small changes to multiple scripts, mostly making default ex
 ------------
 * `git_committer.py` no longer uses `--aggressive` or `--prune=now` on any of its `git gc` commands, because that can make memory usage spike on repos with many many objects.
 
+14 Apr 2025
+-----------
+* `transcode_audio.py` now allows file processing to continue even when tag copying fails.
+* `transcode_audio.py` now has a `--quiet` command-line options to suppress some verbiage.
+
 KNOWN BUGS
 ==========
 * No known bugs listed at the moment. However, check individual module files to be sure that I haven't just forgotten to list something here.

music_file_handling.py

@@ -15,6 +15,7 @@
 import shutil
 import subprocess
 import sys
+import warnings
 
 from pathlib import Path
 from typing import Any, Generator, Iterable, List, TextIO, Union
@@ -232,7 +233,8 @@ def value_of(what: Any) -> str:
     assert from_f.exists()
     assert to_f.exists()
 
-    from_data, to_data = mutagen.File(from_f, easy=True), mutagen.File(to_f, easy=True)
+    from_data = mutagen.File(from_f, easy=True)
+    to_data = mutagen.File(to_f, easy=True)
 
     for data, which_f in ((from_data, from_f), (to_data, to_f)):
         if not data:
@@ -432,6 +434,7 @@ def run_conversion(infile: Path,
                    new_suffix: str = '.mp3',
                    quiet: bool = False,
                    vbrfix: bool = None,
+                   allow_tag_copy_to_fail: bool = False,
                    ) -> Path:
     """Takes INFILE, a file to be processed, and processes it by starting two processes
     modeled by two Popen instances. The first is started using DEC_ARGS as the
@@ -449,6 +452,9 @@ def run_conversion(infile: Path,
     single pass it makes.) If VBRFIX is None (the default), this VBR-fixing pass is
     performed iff the extension of the new file is (case-insensitive) ".mp3".
 
+    If ALLOW_TAG_COPY_TO_FAIL is True, issues a warning instead of failing when tags
+    can't be copied from the old to the new file.
+
     ENC_ARGS is modified before the process is started by appending the name of the
     desired output file after that output filename has been generated. This requires
     that the command be constructed in such a way that it ends with the output
@@ -468,7 +474,7 @@ def run_conversion(infile: Path,
         vbrfix = (new_suffix.strip().casefold().endswith('.mp3'))
 
     outfile = clean_name(infile.with_suffix(new_suffix))
-    enc_args.append(outfile)
+    enc_args.append(str(outfile))
 
     old_stdout, old_stderr = sys.stdout, sys.stderr
     try:
@@ -485,13 +491,20 @@ def run_conversion(infile: Path,
 
         if vbrfix:
             do_vbrfix(outfile, quiet)
-        do_copy_tags(infile, outfile, quiet)
+
+        try:
+            do_copy_tags(infile, outfile, quiet)
+        except Exception as errrr:
+            if allow_tag_copy_to_fail:
+                warnings.warn(f"Could not copy tags from {infile} to {outfile}! The system said: {errrr}")
+            else:
+                raise errrr
+
         if not quiet:
             print('\n\n'.join([th.unicode_of(i) for i in out if i]).strip(), end="\n\n")
     finally:
         sys.stdout, sys.stderr = old_stdout, old_stderr
 
-
     return outfile
 
 

transcode_audio.py

@@ -21,11 +21,15 @@
 def convert_files(filename: List[Type[Path]],
                   delete: bool,
                   mp4: bool,
-                  no_vbrfix: bool) -> None:
+                  no_vbrfix: bool,
+                  quiet: bool) -> None:
     for f in filename:
         assert isinstance(f, Path)
         assert f.is_file()
 
+        if not quiet:
+            print(f"Converting {f.name} ...")
+
         if (ext := f.suffix.strip().casefold()) == '.flac':
             dec_args = [mfh.executable_locations['flac']] + mfh.config['flac options'] + [str(f.resolve())]
         elif ext in ['.wav', '.wave']:
@@ -40,15 +44,16 @@ def convert_files(filename: List[Type[Path]],
 
         # FIXME! mp4 -> mp3 tag conversion gives the literal Python string representation of 1-item lists of strings!
         new_f = mfh.run_conversion(f, dec_args=dec_args, enc_args=enc_args, new_suffix=('.m4a' if mp4 else '.mp3'),
-                                   quiet=False, vbrfix=(not no_vbrfix))
+                                   quiet=False, vbrfix=(not no_vbrfix), allow_tag_copy_to_fail=True)
 
         if new_f.exists() and delete:
             f.unlink()
 
 
 def process_command_line(args: List[str]) -> None:
-    parser = argparse.ArgumentParser(prog='transcode_audio', description=__doc__.strip().split('\n')[0],
-                                     epilog=__doc__.strip().split('\n')[-1])
+    parser = argparse.ArgumentParser(prog='transcode_audio',
+                                     description=__doc__.strip().split('\n\n')[0].replace('\n', ' '),
+                                     epilog=__doc__.strip().split('\n\n')[-1].replace('\n', ' '))
 
     parser.add_argument('filename', type=Path, nargs='+')       # positional argument
     parser.add_argument('-4', '--mp4', '--m4a', '--to-mp4', '--to-m4a', action='store_true',
@@ -57,6 +62,7 @@ def process_command_line(args: List[str]) -> None:
                         action='store_true', help="Delete originals after conversion.")
     parser.add_argument('-n', '--no-vbrfix', action='store_true',
                         help="Don't run VBRfix after conversion, even on .mp3 files.")
+    parser.add_argument('-q', '--quiet', action='store_true', help="Suppress unneeded jibber-jabber.")
 
     convert_files(**vars(parser.parse_args(args)))
 
@@ -68,7 +74,7 @@ def process_command_line(args: List[str]) -> None:
 if __name__ == "__main__":
     force_debugging = False
     if force_debugging:
-        process_command_line(['/home/patrick/Music/by Artist/Daniel Munkus/[2024] Oft Come Devil/Polka Dot Deli - Oft Come Devil - 01 Kings No More.flac'])
+        process_command_line(["/home/patrick/Music/by Artist/The The/[2000] NakedSelf/01 - The The - Boiling Point.mp4"])
         sys.exit()
 
     process_command_line(sys.argv[1:])