From a957f49284c78e08539c8d3e17ab0fbd8e6fe17e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1lmi=20=C3=9E=C3=B3r=20Valgeirsson?= Date: Sun, 18 Mar 2018 00:17:54 +0100 Subject: [PATCH 1/4] Add codecov and failing tests. --- codecov.yml | 6 ++++++ src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java | 2 +- src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java | 2 -- 3 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..76fbf04 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,6 @@ +coverage: + status: + project: + default: + # basic + target: 100% \ No newline at end of file diff --git a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java index ed4264e..90e767b 100644 --- a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java @@ -13,7 +13,7 @@ public class CalculatorTest { @Test public void test() { - //assertThat(calculator.sumAll().get()).isEqualTo(1); // fail un purpose + assertThat(calculator.sumAll().get()).isEqualTo(1); // TODO failing on purpose please fix } diff --git a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java index 09cabc4..d3969f6 100644 --- a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java @@ -11,14 +11,12 @@ public class StringUtilsTest { @Test public void isPalindrome() { - /* assertThat(stringUtils.isPalindrome("aabb")).isFalse(); assertThat(stringUtils.isPalindrome(null)).isFalse(); assertThat(stringUtils.isPalindrome("NotEvenClose")).isFalse(); assertThat(stringUtils.isPalindrome("")).isTrue(); assertThat(stringUtils.isPalindrome("abba")).isTrue(); assertThat(stringUtils.isPalindrome("tattarrattat")).isTrue(); - */ } /** From ac700c18291ab58da9bfa5c4f4e795f3a7fc6db5 Mon Sep 17 00:00:00 2001 From: norenma Date: Thu, 22 Mar 2018 18:45:10 +0100 Subject: [PATCH 2/4] implemented tests and functions --- src/main/java/se/cygni/palmithor/tdd/StringUtils.java | 6 +++++- src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java index 3b36d6b..9906997 100644 --- a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java +++ b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java @@ -4,7 +4,11 @@ public class StringUtils { public boolean isPalindrome(final String str) { - throw new RuntimeException("Not yet implemented"); + if(str == null) { + return false; + } + String reversed = new StringBuilder(str).reverse().toString(); + return str.equals(reversed); } diff --git a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java index 90e767b..097d4a2 100644 --- a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java @@ -13,7 +13,9 @@ public class CalculatorTest { @Test public void test() { - assertThat(calculator.sumAll().get()).isEqualTo(1); // TODO failing on purpose please fix + assertThat(calculator.sumAll(1, 0, -1, 1).get()).isEqualTo(1); // TODO failing on purpose please fix + assertThat(calculator.sumAll(null).isPresent()).isFalse(); // TODO failing on purpose please fix + assertThat(calculator.sumAll().get()).isEqualTo(0); // TODO failing on purpose please fix } From 581d311e676a630dc83ea89e69bbb3ec2813b659 Mon Sep 17 00:00:00 2001 From: norenma Date: Thu, 22 Mar 2018 18:54:24 +0100 Subject: [PATCH 3/4] implemented tests and functions --- src/main/java/se/cygni/palmithor/tdd/StringUtils.java | 2 +- src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java index 9906997..9b17964 100644 --- a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java +++ b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java @@ -19,6 +19,6 @@ public boolean isPalindrome(final String str) { * @return true if str is null, empty or whitespace only, otherwise false */ public boolean isBlank(final String str) { - throw new RuntimeException("Not yet implemented"); + return str == null || str.trim().equals(""); } } diff --git a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java index d3969f6..89aed54 100644 --- a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java @@ -24,6 +24,10 @@ public void isPalindrome() { */ @Test public void isBlank() { - // stringUtils.isBlank() + assertThat(stringUtils.isBlank(null)).isTrue(); + assertThat(stringUtils.isBlank("")).isTrue(); + assertThat(stringUtils.isBlank(" ")).isTrue(); + assertThat(stringUtils.isBlank("2fwefw a")).isFalse(); + assertThat(stringUtils.isBlank(" a")).isFalse(); } } \ No newline at end of file From bbf69791cc33ba9d931bbf4b0e4f9d13bc82a42a Mon Sep 17 00:00:00 2001 From: norenma Date: Thu, 22 Mar 2018 19:07:21 +0100 Subject: [PATCH 4/4] implemented tests and functions --- src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java index 89aed54..8c74011 100644 --- a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java @@ -19,6 +19,7 @@ public void isPalindrome() { assertThat(stringUtils.isPalindrome("tattarrattat")).isTrue(); } + /** * For the following function, you choose if you want to use TDD or not */