diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..76fbf04 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,6 @@ +coverage: + status: + project: + default: + # basic + target: 100% \ No newline at end of file diff --git a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java index 3b36d6b..9b17964 100644 --- a/src/main/java/se/cygni/palmithor/tdd/StringUtils.java +++ b/src/main/java/se/cygni/palmithor/tdd/StringUtils.java @@ -4,7 +4,11 @@ public class StringUtils { public boolean isPalindrome(final String str) { - throw new RuntimeException("Not yet implemented"); + if(str == null) { + return false; + } + String reversed = new StringBuilder(str).reverse().toString(); + return str.equals(reversed); } @@ -15,6 +19,6 @@ public boolean isPalindrome(final String str) { * @return true if str is null, empty or whitespace only, otherwise false */ public boolean isBlank(final String str) { - throw new RuntimeException("Not yet implemented"); + return str == null || str.trim().equals(""); } } diff --git a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java index ed4264e..097d4a2 100644 --- a/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java @@ -13,7 +13,9 @@ public class CalculatorTest { @Test public void test() { - //assertThat(calculator.sumAll().get()).isEqualTo(1); // fail un purpose + assertThat(calculator.sumAll(1, 0, -1, 1).get()).isEqualTo(1); // TODO failing on purpose please fix + assertThat(calculator.sumAll(null).isPresent()).isFalse(); // TODO failing on purpose please fix + assertThat(calculator.sumAll().get()).isEqualTo(0); // TODO failing on purpose please fix } diff --git a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java index 09cabc4..8c74011 100644 --- a/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java +++ b/src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java @@ -11,21 +11,24 @@ public class StringUtilsTest { @Test public void isPalindrome() { - /* assertThat(stringUtils.isPalindrome("aabb")).isFalse(); assertThat(stringUtils.isPalindrome(null)).isFalse(); assertThat(stringUtils.isPalindrome("NotEvenClose")).isFalse(); assertThat(stringUtils.isPalindrome("")).isTrue(); assertThat(stringUtils.isPalindrome("abba")).isTrue(); assertThat(stringUtils.isPalindrome("tattarrattat")).isTrue(); - */ } + /** * For the following function, you choose if you want to use TDD or not */ @Test public void isBlank() { - // stringUtils.isBlank() + assertThat(stringUtils.isBlank(null)).isTrue(); + assertThat(stringUtils.isBlank("")).isTrue(); + assertThat(stringUtils.isBlank(" ")).isTrue(); + assertThat(stringUtils.isBlank("2fwefw a")).isFalse(); + assertThat(stringUtils.isBlank(" a")).isFalse(); } } \ No newline at end of file