Fix tests (with 100% coverage)

Author: nickserv

source/test/controllers/urls_controller_test.rb

@@ -2,7 +2,8 @@
 
 class UrlsControllerTest < ActionController::TestCase
   setup do
-    @url = urls(:one)
+    @valid_url = urls :valid
+    @invalid_url = urls :invalid
   end
 
   test "should get index" do
@@ -16,22 +17,36 @@ class UrlsControllerTest < ActionController::TestCase
     assert_response :success
   end
 
-  test "should create url" do
+  test "should create valid url" do
     assert_difference('Url.count') do
-      post :create, url: { click_count: @url.click_count, long_url: @url.long_url, short_url: @url.short_url }
+      post :create, url: { click_count: @valid_url.click_count, long_url: @valid_url.long_url, short_url: @valid_url.short_url }
     end
 
-    assert_redirected_to url_path(assigns(:url))
+    assert_redirected_to urls_url
   end
 
-  test "should show url" do
-    get :show, id: @url
-    assert_response :success
+  test "should not create invalid url" do
+    assert_no_difference('Url.count') do
+      post :create, url: { click_count: @invalid_url.click_count, long_url: @invalid_url.long_url, short_url: @invalid_url.short_url }
+    end
+  end
+
+  test "should show valid url" do
+    get :show, id: @valid_url
+    assert_response :redirect
+    assert_redirected_to @valid_url.long_url
+  end
+
+  test "should not show nonexistent url" do
+    assert_raise ActionController::RoutingError do
+      get :show, id: 'nonexistent'
+      assert_response :missing
+    end
   end
 
-  test "should destroy url" do
+  test "should destroy valid url" do
     assert_difference('Url.count', -1) do
-      delete :destroy, id: @url
+      delete :destroy, id: @valid_url
     end
 
     assert_redirected_to urls_path

source/test/fixtures/urls.yml

@@ -1,11 +1,11 @@
 # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html
 
-one:
-  short_url: MyString
-  long_url: MyString
-  click_count: 1
+valid:
+  short_url: google
+  long_url: https://www.google.com/
+  click_count: 0
 
-two:
+invalid:
   short_url: MyString
   long_url: MyString
   click_count: 1