chore: retype some things

Author: ThisAMJ

GhostServer/networkmanager.cpp

@@ -120,7 +120,7 @@ void NetworkManager::ScheduleServerThread(std::function<void()> func) {
     g_server_queue_mutex.unlock();
 }
 
-std::vector<Client *> NetworkManager::GetPlayerByName(std::string name)
+std::vector<Client *> NetworkManager::GetPlayerByName(const std::string name)
 {
     std::vector<Client *> matches;
     for (auto &client : this->clients) {
@@ -132,7 +132,7 @@ std::vector<Client *> NetworkManager::GetPlayerByName(std::string name)
     return matches;
 }
 
-Client* NetworkManager::GetClientByID(sf::Uint32 ID)
+Client* NetworkManager::GetClientByID(const sf::Uint32 ID)
 {
     for (auto& client : this->clients) {
         if (client.ID == ID) {
@@ -143,7 +143,7 @@ Client* NetworkManager::GetClientByID(sf::Uint32 ID)
     return nullptr;
 }
 
-std::vector<Client *> NetworkManager::GetClientByIP(sf::IpAddress ip) {
+std::vector<Client *> NetworkManager::GetClientByIP(const sf::IpAddress ip) {
     std::vector<Client *> clients;
     for (auto& client : this->clients) {
         if (client.IP == ip) {
@@ -214,7 +214,7 @@ void NetworkManager::StopServer()
     GHOST_LOG("Server stopped!");
 }
 
-void NetworkManager::DisconnectPlayer(Client& c, const char *reason)
+void NetworkManager::DisconnectPlayer(Client& c, const std::string reason)
 {
     sf::Packet packet;
     packet << HEADER::DISCONNECT << c.ID;

GhostServer/networkmanager.h

@@ -127,16 +127,16 @@ class NetworkManager
 
     void ScheduleServerThread(std::function<void()> func);
 
-    std::vector<Client *> GetPlayerByName(std::string name);
-    Client* GetClientByID(sf::Uint32 ID);
-    std::vector<Client *> GetClientByIP(sf::IpAddress ip);
+    std::vector<Client *> GetPlayerByName(const std::string name);
+    Client* GetClientByID(const sf::Uint32 ID);
+    std::vector<Client *> GetClientByIP(const sf::IpAddress ip);
 
     bool StartServer(const int port);
     void StopServer();
     void RunServer();
 
     bool ShouldBlockConnection(const sf::IpAddress &ip);
-    void DisconnectPlayer(Client &client, const char *reason);
+    void DisconnectPlayer(Client &client, const std::string reason);
     void StartCountdown(const std::string preCommands, const std::string postCommands, const int duration);
     void SetAccept(bool players, bool accept);
     void SetAlwaysListClients(bool alwaysList);