Fix stdin TTY handling and add integration tests for issue #511

Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/oxc-project/oxc-node/sessions/6f816136-6098-46d5-8958-6181480b5826

Author: Claude

packages/cli/src/index.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-import { exec, execSync } from "node:child_process";
+import { execSync, spawn } from "node:child_process";
 import process from "node:process";
 
 import { Builtins, Cli, Command, Option, Usage } from "clipanion";
@@ -52,22 +52,14 @@ class MainCommand extends Command {
       });
       return;
     }
-    const cp = exec(`node --enable-source-maps --import ${register} ${args}`, {
+    const cp = spawn(`node`, [`--enable-source-maps`, `--import`, register, ...this.args], {
       env: process.env,
       cwd: process.cwd(),
+      stdio: `inherit`,
     });
     cp.addListener(`error`, (error) => {
       console.error(error);
     });
-    if (cp.stdin) {
-      this.context.stdin.pipe(cp.stdin);
-    }
-    if (cp.stdout) {
-      cp.stdout.pipe(this.context.stdout);
-    }
-    if (cp.stderr) {
-      cp.stderr.pipe(this.context.stderr);
-    }
     cp.addListener(`exit`, (code) => {
       process.exit(code ?? 0);
     });

packages/integrate-ava/__tests__/fixtures/stdin-echo.ts

@@ -0,0 +1,13 @@
+#!/usr/bin/env node
+// Test fixture that reads from stdin and echoes it back
+import process from "node:process";
+
+let data = "";
+
+process.stdin.on("data", (chunk) => {
+  data += chunk;
+});
+
+process.stdin.on("end", () => {
+  console.log(data.trim());
+});

packages/integrate-ava/__tests__/fixtures/tty-check.ts

@@ -0,0 +1,11 @@
+#!/usr/bin/env node
+// Test fixture to check if stdin has TTY properties
+import process from "node:process";
+
+// Output stdin.isTTY status
+console.log(
+  JSON.stringify({
+    isTTY: process.stdin.isTTY,
+    hasSetRawMode: typeof process.stdin.setRawMode === "function",
+  }),
+);

packages/integrate-ava/__tests__/stdin-tty.spec.ts

@@ -0,0 +1,111 @@
+import test from "ava";
+import { spawn, spawnSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+import { promisify } from "node:util";
+
+const FIXTURE_PATHS = new Map(
+  ["tty-check.ts", "stdin-echo.ts"].map((name) => [
+    name,
+    fileURLToPath(new URL(`./fixtures/${name}`, import.meta.url)),
+  ]),
+);
+
+const getFixturePath = (fixtureName: string) => {
+  const resolved = FIXTURE_PATHS.get(fixtureName);
+  if (!resolved) {
+    throw new Error(`Unknown fixture: ${fixtureName}`);
+  }
+  return resolved;
+};
+
+const oxnodePath = fileURLToPath(new URL("../../cli/dist/index.js", import.meta.url));
+
+test("CLI preserves TTY properties when stdin is a TTY", (t) => {
+  const fixturePath = getFixturePath("tty-check.ts");
+
+  // Run with oxnode via spawn to inherit stdio
+  // Note: In CI environment, stdin might not be a TTY, but we can still test
+  // that oxnode doesn't break TTY when one is available
+  const result = spawnSync(process.execPath, [oxnodePath, fixturePath], {
+    encoding: "utf8",
+    env: {
+      ...process.env,
+      NODE_OPTIONS: undefined,
+    },
+  });
+
+  t.falsy(result.error, result.error?.message);
+  t.is(result.status, 0, `oxnode should run successfully. stderr: ${result.stderr}`);
+
+  const output = JSON.parse(result.stdout.trim());
+
+  // In a non-TTY environment (like CI), isTTY will be undefined and omitted from JSON
+  // In a TTY environment, isTTY should be true
+  // The key is that we're checking it's not explicitly broken by piping
+  if ("isTTY" in output) {
+    t.true(output.isTTY, "when present, isTTY should be true");
+  }
+  // When stdin is a TTY, setRawMode should be available
+  // When stdin is not a TTY, setRawMode might not be available
+  t.is(typeof output.hasSetRawMode, "boolean", "hasSetRawMode should be a boolean");
+});
+
+test("CLI properly handles stdin piping", async (t) => {
+  const fixturePath = getFixturePath("stdin-echo.ts");
+  const testInput = "Hello from stdin test";
+
+  // Spawn oxnode and pipe input to it
+  const child = spawn(process.execPath, [oxnodePath, fixturePath], {
+    env: {
+      ...process.env,
+      NODE_OPTIONS: undefined,
+    },
+  });
+
+  let stdout = "";
+  let stderr = "";
+
+  child.stdout?.on("data", (chunk) => {
+    stdout += chunk;
+  });
+
+  child.stderr?.on("data", (chunk) => {
+    stderr += chunk;
+  });
+
+  // Write test input to stdin and close it
+  child.stdin?.write(testInput);
+  child.stdin?.end();
+
+  // Wait for child to exit
+  await new Promise((resolve) => {
+    child.on("exit", resolve);
+  });
+
+  t.is(stderr, "", "should not produce any errors");
+  t.is(stdout.trim(), testInput, "should echo the input correctly");
+});
+
+test("CLI with node directly preserves TTY (baseline comparison)", (t) => {
+  const fixturePath = getFixturePath("tty-check.ts");
+
+  // Run with node directly with --import for baseline comparison
+  const result = spawnSync(process.execPath, ["--import", "@oxc-node/core/register", fixturePath], {
+    encoding: "utf8",
+    env: {
+      ...process.env,
+      NODE_OPTIONS: undefined,
+    },
+  });
+
+  t.falsy(result.error, result.error?.message);
+  t.is(result.status, 0, "node with --import should run successfully");
+
+  const output = JSON.parse(result.stdout.trim());
+
+  // This is the baseline - both oxnode and node --import should behave the same
+  if ("isTTY" in output) {
+    t.true(output.isTTY, "baseline: when present, isTTY should be true");
+  }
+  t.is(typeof output.hasSetRawMode, "boolean", "baseline: hasSetRawMode should be a boolean");
+});