Skip to content

Commit 4e430c0

Browse files
fix: Tags column can't be shown/hidden (#281)
The Show/Hide Columns menu had no Tags checkbox, and 'tags' was absent from the column-visibility listener list, defaults map, and class map — so the column couldn't be toggled at all. Added the checkbox (in column order) and wired tags through parseColumnVisibility/applyColumnVisibility/ the change-listener list. Existing users default to tags visible.
1 parent 13bc903 commit 4e430c0

5 files changed

Lines changed: 10 additions & 3 deletions

File tree

budget/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Fixed
1111
- Dropdowns in the transaction list (the column-configuration gear menu and the in-cell category/tag/account editors) were cut off when the table had only a few rows, because the table area was shorter than the dropdowns. The transaction table now fills the available height, so every dropdown has room to open in full ([#280](https://github.com/otherworld-dev/Budget/issues/280))
12+
- The Tags column couldn't be shown/hidden — the Show/Hide Columns menu was missing a Tags entry, and the column wasn't wired into the visibility logic. Tags can now be toggled like the other columns ([#281](https://github.com/otherworld-dev/Budget/issues/281))
1213

1314
## [2.30.1] - 2026-06-13
1415

budget/js/budget-app.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

budget/js/budget-app.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

budget/src/main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ class BudgetApp {
391391
});
392392

393393
// Column visibility toggles
394-
['date', 'description', 'vendor', 'category', 'amount', 'account'].forEach(col => {
394+
['date', 'description', 'vendor', 'category', 'tags', 'amount', 'account'].forEach(col => {
395395
const checkbox = document.getElementById(`col-toggle-${col}`);
396396
if (checkbox) {
397397
checkbox.addEventListener('change', () => {
@@ -3950,6 +3950,7 @@ class BudgetApp {
39503950
description: true,
39513951
vendor: true,
39523952
category: true,
3953+
tags: true,
39533954
amount: true,
39543955
balance: true,
39553956
account: true
@@ -3976,6 +3977,7 @@ class BudgetApp {
39763977
description: 'description-column',
39773978
vendor: 'vendor-column',
39783979
category: 'category-column',
3980+
tags: 'tags-column',
39793981
amount: 'amount-column',
39803982
balance: 'balance-column',
39813983
account: 'account-column'

budget/templates/index.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,6 +1630,10 @@ class="app-navigation-search-clear icon-close"
16301630
<input type="checkbox" id="col-toggle-category" checked>
16311631
<span><?php p($l->t('Category')); ?></span>
16321632
</label>
1633+
<label>
1634+
<input type="checkbox" id="col-toggle-tags" checked>
1635+
<span><?php p($l->t('Tags')); ?></span>
1636+
</label>
16331637
<label>
16341638
<input type="checkbox" id="col-toggle-amount" checked>
16351639
<span><?php p($l->t('Amount')); ?></span>

0 commit comments

Comments
 (0)