Public Shelf Still Showing if no Books

[ThatDeltaGuy]

What went wrong?

I have a public shelf but if i don't share the library or libraries that make up that shelf with a user then it just displays as an empty shelf with "This collection has no books!". It also still displays the full count of books for the shelf next to the shelf name, rather than the count the user has access to.

I would expect the book count to reflect the count that the user will see on the shelf, and if that count is zero, for the shelf to be hidden from the user.

As an addendum, it could be a good feature to have 2 options under visibility. 'Public shelf' is a bit confusing as to whether it lets people access books from a library they don’t have access to or not. adding a "Share books with all users" option would nix this confusion and also open up a way to share some books to users from a library you don't necessarily want then to have full access to. Or even open up the possibility of not sharing any libraries and just shelves. (The Content Restrictions should still apply)

How can we reproduce it?

1. create a public shelf
2. add books from library A, and B
3. Add a user with only access to Library C
4. Log in as user
5. Click on the shelf.
6. See 0 books.

What Build of Grimmory are you on?

Stable

Your setup

• latest version - have to assume 3.2.4
• unraid 7.3.1
• firefox

Screenshots or error messages (optional)

No response

Before submitting

• I've searched existing discussions and this hasn't been reported yet
• I've reviewed this report and have completed it as fully as I can