Skip to content

Commit aa85a3c

Browse files
Improve empty secret name validation in Azure Vault Config Provider
1 parent 5412eb9 commit aa85a3c

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

ojdbc-provider-azure/src/main/java/oracle/jdbc/provider/azure/configuration/AzureVaultURLParser.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,15 @@ static void parseVaultSecretUri(
7070

7171
String path = urlBuilder.getPath();
7272

73-
if (!path.contains("/secrets"))
73+
if (!path.contains("/secrets/"))
7474
throw new IllegalArgumentException("The Vault Secret URI should " +
7575
"contain \"/secrets\" following by the name of the Secret: " +
7676
vaultSecretUri);
7777

78-
String secretName = path.replace("/secrets", "");
78+
String secretName = path.replace("/secrets/", "");
79+
if (secretName.trim().isEmpty()){
80+
throw new IllegalArgumentException("Missing secret name in Vault URI: " + vaultSecretUri);
81+
}
7982
builder.add("value", KeyVaultSecretFactory.SECRET_NAME, secretName);
8083
}
8184
}

0 commit comments

Comments
 (0)