docs: improve advanced sso page#9507
Draft
wvandeun wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- This PR looks safe to merge overall, but there is a minor documentation accuracy issue in
docs/docs/deploy-manage/user-management/sso/advanced-sso.mdx. - The summary currently states all three group-mapping approaches require IdP group claims, which conflicts with the documented default-group path intended for setups without group claims.
- Because the issue is low severity (3/10) and limited to wording, risk is minimal, but it could still mislead SSO configuration decisions for readers.
- Pay close attention to
docs/docs/deploy-manage/user-management/sso/advanced-sso.mdx- ensure the summary distinguishes the no-group-claims default-group flow from claim-dependent mappings.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/docs/deploy-manage/user-management/sso/advanced-sso.mdx">
<violation number="1" location="docs/docs/deploy-manage/user-management/sso/advanced-sso.mdx:57">
P3: The new summary incorrectly says all three group-mapping approaches require IdP group claims, but the default-group path is explicitly for cases with no group claims.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
| - **[Auto-create groups](#auto-create-groups-from-claims)** — let Infrahub create groups from the claims on first login. | ||
| - **[Set a default group](#set-a-default-group)** — assign a fallback group when no claim maps to one. | ||
|
|
||
| All three rely on your identity provider sending group information in the first place. Configure that first, then pick an approach. [How Infrahub resolves membership](#how-infrahub-resolves-membership) explains how the approaches interact on each login. |
Contributor
There was a problem hiding this comment.
P3: The new summary incorrectly says all three group-mapping approaches require IdP group claims, but the default-group path is explicitly for cases with no group claims.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/docs/deploy-manage/user-management/sso/advanced-sso.mdx, line 57:
<comment>The new summary incorrectly says all three group-mapping approaches require IdP group claims, but the default-group path is explicitly for cases with no group claims.</comment>
<file context>
@@ -47,13 +48,15 @@ oidc_providers = ["provider1", "provider2"]
+- **[Auto-create groups](#auto-create-groups-from-claims)** — let Infrahub create groups from the claims on first login.
+- **[Set a default group](#set-a-default-group)** — assign a fallback group when no claim maps to one.
+
+All three rely on your identity provider sending group information in the first place. Configure that first, then pick an approach. [How Infrahub resolves membership](#how-infrahub-resolves-membership) explains how the approaches interact on each login.
-### Step 1: Configure group claims in your identity provider
</file context>
Suggested change
| All three rely on your identity provider sending group information in the first place. Configure that first, then pick an approach. [How Infrahub resolves membership](#how-infrahub-resolves-membership) explains how the approaches interact on each login. | |
| Map-to-existing and auto-creation rely on your identity provider sending group information. You can also set a default group for users when no claim grants membership. Configure claims first, then pick an approach. [How Infrahub resolves membership](#how-infrahub-resolves-membership) explains how the approaches interact on each login. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Clarifies and restructures the Advanced SSO docs to explain group mapping workflows: map to existing groups, auto-create from claims (regex filters, multiple patterns, per-login cap, audit events, provenance), and default group fallback. Adds IdP group-claim setup steps, log examples, a membership-resolution overview, and sets
toc_max_heading_level: 4.Written for commit 9f708f9. Summary will update on new commits.