Skip to content

fix(ci): drop 'edited' trigger from bug reviewer agent#9443

Merged
polmichel merged 1 commit into
stablefrom
pmi-20260603-fix-cubic-blocking-reviewer-step
Jun 3, 2026
Merged

fix(ci): drop 'edited' trigger from bug reviewer agent#9443
polmichel merged 1 commit into
stablefrom
pmi-20260603-fix-cubic-blocking-reviewer-step

Conversation

@polmichel

@polmichel polmichel commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Root cause

The bug reviewer agent triggers on pull_request edited events. On PR #9438, cubic-dev-ai[bot] edited the PR description. This spawned a second workflow run with cubic-dev-ai[bot] as the triggering actor, which:

  1. Cancelled the legitimate run via the cancel-in-progress: true concurrency group keyed on the PR number: cancelled run
  2. Failed the actor gate itselfcubic-dev-ai[bot] is neither a team member nor in the allowed bots list, so pre_activation returned activated=false and the agent job was skipped: skipped run

Net result: no review was ever posted. Since cubic edits the description of every PR it reviews, this race affects every bug-pipeline PR.

Fix

Drop edited from the trigger types. It is redundant for the iteration loop: every pipeline step that needs a (re-)review ends with a push (synchronize).

Lock file recompiled with gh-aw v0.77.5.

This PR is chained with v0.77.5 gh aw upgrade PR #9358


Summary by cubic

Removed edited from the bug reviewer workflow’s pull_request triggers to prevent non-allowed bot description edits from canceling the in-flight reviewer run. Reviews still re-trigger on synchronize, with opened and reopened as entry points; lock file recompiled with github/gh-aw-actions/setup v0.77.5.

Written for commit 436878f. Summary will update on new commits.

Review in cubic

PR body edits by non-allowed bots (e.g. cubic-dev-ai appending its review
summary) spawn a workflow run that fails the actor gate and, via the
cancel-in-progress concurrency group, cancels the legitimate in-flight
reviewer run. Every pipeline iteration ends with a push, so 'synchronize'
(plus 'opened'/'reopened') is sufficient to re-trigger the reviewer.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the group/ci Issue related to the CI pipeline label Jun 3, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. This PR removes the 'edited' trigger from the workflow to prevent bot-triggered race conditions, with no changes to business logic, infrastructure, or security; the changes are minimal and well-isolated.

Re-trigger cubic

@polmichel polmichel requested a review from a team June 3, 2026 11:16
@polmichel polmichel marked this pull request as ready for review June 3, 2026 11:16
Base automatically changed from pmi-20260526-gh-aw-update to stable June 3, 2026 15:17
@polmichel polmichel merged commit 7fe5303 into stable Jun 3, 2026
45 checks passed
@polmichel polmichel deleted the pmi-20260603-fix-cubic-blocking-reviewer-step branch June 3, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants