From e9bc246d4b5397ac12131975aba3b3499af6274a Mon Sep 17 00:00:00 2001 From: Theo Barber-Bany Date: Tue, 23 Jun 2026 12:11:16 +0100 Subject: [PATCH] OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations --- .../terminationmessagepolicy/monitortest.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go b/pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go index 3908ff1817cc..24529a402d51 100644 --- a/pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go +++ b/pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go @@ -111,14 +111,12 @@ func (w *terminationMessagePolicyChecker) CollectData(ctx context.Context, stora if container.TerminationMessagePolicy != corev1.TerminationMessageFallbackToLogsOnError { failuresByNamespace[pod.Namespace] = append(failuresByNamespace[pod.Namespace], fmt.Sprintf("pods/%s containers[%v]", pod.Name, container.Name)) - } } for _, container := range pod.Spec.EphemeralContainers { if container.TerminationMessagePolicy != corev1.TerminationMessageFallbackToLogsOnError { failuresByNamespace[pod.Namespace] = append(failuresByNamespace[pod.Namespace], fmt.Sprintf("pods/%s ephemeralContainers[%v]", pod.Name, container.Name)) - } } } @@ -138,7 +136,6 @@ func (w *terminationMessagePolicyChecker) CollectData(ctx context.Context, stora // per TRT-2084 these were erroneously allowed to flake, so grandfather them in for now. // they should be fixed and removed from here: "openshift-backplane": sets.NewString("pods/osd-delete-backplane-serviceaccounts"), // filed OCPBUGS-84527 to fix - "openshift-cloud-controller-manager": sets.NewString("pods/aws-cloud-controller-manager"), // filed OCPBUGS-84512 to fix "openshift-cluster-machine-approver": sets.NewString("pods/machine-approver-capi"), // filed OCPBUGS-84521 to fix "openshift-cluster-version": sets.NewString("pods/version--"), // filed OCPBUGS-84513 to fix "openshift-cnv": sets.NewString( // filed OCPBUGS-84522 to fix