chore(SREP-4485): fix lint CI by switching to --new-from-rev in Makefile

Replace unreliable `new: true` golangci.yml setting with `--new-from-rev`
passed via Makefile. In Prow CI uses PULL_BASE_SHA; locally falls back to
origin/HEAD. Also updates boilerplate (UBI image, OWNERS_ALIASES, commit hash),
removes stale .claude/commands/pre-commit.md, and cleans up fips.go.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: charlesgong

.claude/commands/pre-commit.md

@@ -5,6 +5,7 @@
 aliases:
   srep-functional-team-aurora:
     - AlexSmithGH
+    - BATMAN-JD
     - dakotalongRH
     - eth1030
     - joshbranham

OWNERS_ALIASES

@@ -1 +1 @@
-b6e7575196e8c17274c85d2c22178ad51290c237
+c2342f1bcec55d87fd028e5c1d7f105c745eb32e

boilerplate/_data/last-boilerplate-commit

@@ -5,6 +5,7 @@
 aliases:
   srep-functional-team-aurora:
     - AlexSmithGH
+    - BATMAN-JD
     - dakotalongRH
     - eth1030
     - joshbranham

boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES

@@ -62,11 +62,9 @@ linters:
 
 run:
   timeout: 5m
-  # Only check new code, not existing issues
-  # This uses git to compare against the base branch (typically master/main)
-  new: true
-  # Alternatively, you can specify a specific revision:
-  # new-from-rev: origin/master
+  # Incremental linting (new-from-rev) is passed via the Makefile's
+  # go-check target. In CI it uses PULL_BASE_SHA (guaranteed to exist
+  # even in shallow clones); locally it falls back to origin/HEAD.
 
 formatters:
   enable:

boilerplate/openshift/golang-osd-operator/golangci.yml

@@ -172,10 +172,19 @@ docker-login:
 	mkdir -p ${CONTAINER_ENGINE_CONFIG_DIR}
 	@${CONTAINER_ENGINE} login -u="${REGISTRY_USER}" -p="${REGISTRY_TOKEN}" quay.io
 
+# Only lint new/changed code. In Prow CI, PULL_BASE_SHA points to the
+# base commit and is guaranteed to exist in the checkout (even shallow
+# clones). Locally, fall back to the default branch ref.
+ifdef PULL_BASE_SHA
+LINT_NEW_FROM_REV := $(PULL_BASE_SHA)
+else
+LINT_NEW_FROM_REV := $(shell git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's|refs/remotes/||')
+endif
+
 .PHONY: go-check
 go-check: ## Golang linting and other static analysis
 	${CONVENTION_DIR}/ensure.sh golangci-lint
-	${GOENV} GOLANGCI_LINT_CACHE=${GOLANGCI_LINT_CACHE} golangci-lint run -c ${CONVENTION_DIR}/golangci.yml ./...
+	${GOENV} GOLANGCI_LINT_CACHE=${GOLANGCI_LINT_CACHE} golangci-lint run -c ${CONVENTION_DIR}/golangci.yml $(if $(LINT_NEW_FROM_REV),--new-from-rev=$(LINT_NEW_FROM_REV)) ./...
 
 .PHONY: go-generate
 go-generate:

boilerplate/openshift/golang-osd-operator/standard.mk

@@ -6,7 +6,7 @@ WORKDIR ${OPERATOR_PATH}
 # Build
 RUN make go-build
 
-FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778072020
+FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778562320
 ENV OPERATOR_PATH=/gcp-project-operator \
     OPERATOR_BIN=gcp-project-operator
 

build/Dockerfile

@@ -4,7 +4,7 @@ COPY ${SAAS_OPERATOR_DIR} manifests
 RUN initializer --permissive
 
 # ubi-micro does not work for clusters with fips enabled unless we make OpenSSL available
-FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778072020
+FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778562320
 
 COPY --from=builder /bin/registry-server /bin/registry-server
 COPY --from=builder /bin/grpc_health_probe /bin/grpc_health_probe

build/Dockerfile.olm-registry

@@ -12,5 +12,5 @@ import (
 )
 
 func init() {
-	_, _ = fmt.Println("***** Starting with FIPS crypto enabled *****")
+	fmt.Println("***** Starting with FIPS crypto enabled *****")
 }