Skip to content

Commit 60fd088

Browse files
authored
Increment to 3.1.0.0 (#1301)
* Increment to 3.1.0.0 Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> * Upgrade start-opensearch to v6, include jdk-version to use Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> * Bug-Fix: Display alerts when a configured correlation rule is opened Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> --------- Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
1 parent ea4e2ab commit 60fd088

6 files changed

Lines changed: 300 additions & 276 deletions

File tree

.github/workflows/cypress-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
- '*'
99
env:
1010
OPENSEARCH_DASHBOARDS_VERSION: 'main'
11-
OPENSEARCH_VERSION: '3.0.0-SNAPSHOT'
11+
OPENSEARCH_VERSION: '3.1.0-SNAPSHOT'
1212
SECURITY_ANALYTICS_BRANCH: 'main'
1313
GRADLE_VERSION: '7.6.1'
1414
jobs:

.github/workflows/verify-binary-installation.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 'Install Dashboards with Plugin via Binary'
22

33
on: [push, pull_request]
44
env:
5-
OPENSEARCH_VERSION: '3.0.0'
5+
OPENSEARCH_VERSION: '3.1.0'
66
CI: 1
77
# avoid warnings like "tput: No value for $TERM and no -T specified"
88
TERM: xterm
@@ -20,6 +20,12 @@ jobs:
2020
- name: Checkout Branch
2121
uses: actions/checkout@v3
2222

23+
- name: Set up JDK
24+
uses: actions/setup-java@v2
25+
with:
26+
distribution: temurin # Temurin is a distribution of adoptium
27+
java-version: 21
28+
2329
- name: Set env
2430
run: |
2531
opensearch_version=$(node -p "require('./opensearch_dashboards.json').opensearchDashboardsVersion")
@@ -29,10 +35,11 @@ jobs:
2935
shell: bash
3036

3137
- name: Run Opensearch
32-
uses: derek-ho/start-opensearch@v2
38+
uses: derek-ho/start-opensearch@v6
3339
with:
3440
opensearch-version: ${{ env.OPENSEARCH_VERSION }}
3541
security-enabled: false
42+
jdk-version: 21
3643

3744
- name: Run Dashboard
3845
id: setup-dashboards
@@ -52,4 +59,3 @@ jobs:
5259
run: |
5360
timeout 300 bash -c 'while [[ "$(curl http://localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
5461
shell: bash
55-

opensearch_dashboards.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "securityAnalyticsDashboards",
3-
"version": "3.0.0.0",
4-
"opensearchDashboardsVersion": "3.0.0",
3+
"version": "3.1.0.0",
4+
"opensearchDashboardsVersion": "3.1.0",
55
"configPath": ["opensearch_security_analytics"],
66
"requiredPlugins": ["data", "navigation", "opensearchDashboardsUtils", "contentManagement"],
77
"optionalPlugins": ["dataSource", "dataSourceManagement"],

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "opensearch_security_analytics_dashboards",
3-
"version": "3.0.0.0",
3+
"version": "3.1.0.0",
44
"description": "OpenSearch Dashboards plugin for Security Analytics",
55
"main": "index.js",
66
"license": "Apache-2.0",

public/pages/Correlations/containers/CreateCorrelationRule.tsx

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -906,6 +906,12 @@ export const CreateCorrelationRule: React.FC<CreateCorrelationRuleProps> = (
906906
props.resetForm();
907907
}
908908

909+
useEffect(() => {
910+
if (trigger?.id) {
911+
setShowForm(true);
912+
}
913+
}, [trigger?.id]);
914+
909915
return (
910916
<Form>
911917
<ContentPanel
@@ -1010,15 +1016,17 @@ export const CreateCorrelationRule: React.FC<CreateCorrelationRuleProps> = (
10101016
<p>Get an alert on the correlation between the findings.</p>
10111017
</EuiText>
10121018
<EuiSpacer size="m" />
1013-
<EuiCompressedFormRow>
1014-
<EuiFlexGroup>
1015-
<EuiFlexItem grow={false}>
1016-
<EuiSmallButton onClick={() => setShowForm(!showForm)}>
1017-
Add Alert Trigger
1018-
</EuiSmallButton>
1019-
</EuiFlexItem>
1020-
</EuiFlexGroup>
1021-
</EuiCompressedFormRow>
1019+
{!showForm && (
1020+
<EuiCompressedFormRow>
1021+
<EuiFlexGroup>
1022+
<EuiFlexItem grow={false}>
1023+
<EuiSmallButton onClick={() => setShowForm(!showForm)}>
1024+
Add Alert Trigger
1025+
</EuiSmallButton>
1026+
</EuiFlexItem>
1027+
</EuiFlexGroup>
1028+
</EuiCompressedFormRow>
1029+
)}
10221030
{showForm && (
10231031
<>
10241032
<EuiSpacer size="m" />

0 commit comments

Comments
 (0)