[fix] Windows linter errors (#577)

* Fix windows-linter-errors

Author: EthanHeilman

.gitattributes

@@ -1,2 +1,2 @@
 # Auto detect text files and perform LF normalization
-* text=auto
+*.go text eol=lf

commands/permissions_fix_windows_test.go

@@ -11,17 +11,24 @@ import (
 	"github.com/openpubkey/opkssh/policy"
 	"github.com/openpubkey/opkssh/policy/files"
 	"github.com/spf13/afero"
+	"github.com/stretchr/testify/require"
 )
 
 func TestRunPermissionsFix_AppliesRequiredACEs_Windows(t *testing.T) {
 	// Setup in-memory fs with system policy file
 	mem := afero.NewMemMapFs()
 	systemPolicy := policy.SystemDefaultPolicyPath
-	afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	err := afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	require.NoError(t, err, "Failed to write system policy file")
+
 	// ensure plugins dir exists but no ACEs present
 	pluginsDir := policy.GetSystemConfigBasePath() + "/policy.d"
-	mem.MkdirAll(pluginsDir, 0o750)
-	afero.WriteFile(mem, pluginsDir+"/plugin.yml", []byte("a"), 0o644)
+	err = mem.MkdirAll(pluginsDir, 0o750)
+	if err != nil {
+		t.Fatalf("Failed to create plugins dir: %v", err)
+	}
+	err = afero.WriteFile(mem, pluginsDir+"/plugin.yml", []byte("a"), 0o644)
+	require.NoError(t, err, "Failed to write plugin file")
 
 	mfs := &mockFileSystem{
 		fs:        mem,
@@ -37,7 +44,7 @@ func TestRunPermissionsFix_AppliesRequiredACEs_Windows(t *testing.T) {
 		Yes:           true,
 	}
 
-	err := p.Fix()
+	err = p.Fix()
 	if err != nil {
 		t.Fatalf("Fix failed: %v", err)
 	}
@@ -68,7 +75,8 @@ func TestRunPermissionsFix_SkipsExistingACEs_Windows(t *testing.T) {
 	// Setup in-memory fs with system policy file, ACEs already present
 	mem := afero.NewMemMapFs()
 	systemPolicy := policy.SystemDefaultPolicyPath
-	afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	err := afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	require.NoError(t, err, "Failed to write system policy file")
 
 	mfs := &mockFileSystem{
 		fs: mem,
@@ -91,7 +99,7 @@ func TestRunPermissionsFix_SkipsExistingACEs_Windows(t *testing.T) {
 		Yes:           true,
 	}
 
-	err := p.Fix()
+	err = p.Fix()
 	if err != nil {
 		t.Fatalf("Fix failed: %v", err)
 	}
@@ -108,7 +116,8 @@ func TestRunPermissionsFix_NoSystemACE_Windows(t *testing.T) {
 	// Verify that SYSTEM:F ACE is never applied
 	mem := afero.NewMemMapFs()
 	systemPolicy := policy.SystemDefaultPolicyPath
-	afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	err := afero.WriteFile(mem, systemPolicy, []byte("x"), 0o644)
+	require.NoError(t, err, "Failed to write system policy file")
 
 	mfs := &mockFileSystem{
 		fs:        mem,
@@ -124,7 +133,7 @@ func TestRunPermissionsFix_NoSystemACE_Windows(t *testing.T) {
 		Yes:           true,
 	}
 
-	err := p.Fix()
+	err = p.Fix()
 	if err != nil {
 		t.Fatalf("Fix failed: %v", err)
 	}

policy/files/acl_windows.go

@@ -150,7 +150,7 @@ func (w *WindowsACLVerifier) VerifyACL(path string, expected ExpectedACL) (ACLRe
 	}
 	// Ensure security descriptor memory is freed
 	if pSD != 0 {
-		defer procLocalFree.Call(pSD)
+		defer procLocalFree.Call(pSD) //nolint:errcheck // free failure not worth handling
 	}
 
 	// Lookup owner name if available

policy/files/fileperms_ops_windows_acl.go

@@ -224,7 +224,7 @@ func (w *WindowsACLFilePermsOps) ApplyACE(path string, ace ACE) error {
 		return fmt.Errorf("GetNamedSecurityInfoW failed: %d", ret)
 	}
 	if pSD != 0 {
-		defer procLocalFree.Call(pSD)
+		defer procLocalFree.Call(pSD) //nolint:errcheck // free failure not worth handling
 	}
 
 	// Build EXPLICIT_ACCESS
@@ -284,7 +284,7 @@ func (w *WindowsACLFilePermsOps) ApplyACE(path string, ace ACE) error {
 	if pNewAcl == 0 {
 		return fmt.Errorf("SetEntriesInAclW returned nil ACL")
 	}
-	defer procLocalFree.Call(pNewAcl)
+	defer procLocalFree.Call(pNewAcl) //nolint:errcheck // free failure not worth handling
 
 	// Apply new DACL to the file
 	ret3, _, err := procSetNamedSecurityInfo.Call(