Skip to content

Commit 78c2dfa

Browse files
committed
mlog: Integrate logging into MoQPicoServerBase connections
- Log DCID for incoming QUIC connections in onNewConnectionImpl() - Log DCID for WebTransport CONNECT in onWebTransportConnectImpl() - Enable MLogger creation and attachment to MoQ sessions
1 parent 4cac8fd commit 78c2dfa

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

moxygen/openmoq/transport/pico/MoQPicoServerBase.cpp

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,16 @@ void MoQPicoServerBase::onNewConnectionImpl(void* vcnx) {
466466
onWebTransportCreated(*webTransport);
467467

468468
auto moqSession = createSession(webTransport, executor_);
469+
if (mLoggerFactory_) {
470+
auto logger = createLogger();
471+
auto picoCid = picoquic_get_local_cnxid(cnx);
472+
if (picoCid.id_len > 0) {
473+
logger->setDcid(
474+
quic::ConnectionId::createAndMaybeCrash(
475+
std::vector<uint8_t>(picoCid.id, picoCid.id + picoCid.id_len)));
476+
}
477+
moqSession->setLogger(logger);
478+
}
469479
webTransport->setHandler(moqSession.get());
470480

471481
const char* alpn = picoquic_tls_get_negotiated_alpn(cnx);
@@ -564,6 +574,16 @@ int MoQPicoServerBase::onWebTransportConnectImpl(
564574

565575
// Create MoQSession
566576
auto moqSession = createSession(webTransport, executor_);
577+
if (mLoggerFactory_) {
578+
auto logger = createLogger();
579+
auto picoCid = picoquic_get_local_cnxid(cnx);
580+
if (picoCid.id_len > 0) {
581+
logger->setDcid(
582+
quic::ConnectionId::createAndMaybeCrash(
583+
std::vector<uint8_t>(picoCid.id, picoCid.id + picoCid.id_len)));
584+
}
585+
moqSession->setLogger(logger);
586+
}
567587
webTransport->setHandler(moqSession.get());
568588

569589
// Set path from the HTTP/3 CONNECT request. Authority is not set because

0 commit comments

Comments
 (0)