feat: Added private key and passphrase authentication for snowflake connection

Author: rgopalrao-sonata-png

enterprise_data/api/v1/views/lpr_data_source_snowflake.py

@@ -5,7 +5,7 @@
 -------
 SnowflakeCourseProgressSource
     Fetches COURSE_PROGRESS per ``(enterprise_customer_uuid, user_email, courserun_key)``
-    from ``LEARNER_PROGRESS_REPORT_INTERNAL``.  Results are cached per (enterprise, pair).
+    from ``LEARNER_PROGRESS_REPORT_EXTERNAL``.  Results are cached per (enterprise, pair).
 
 SnowflakeCoursePassingGradeSource
     Fetches LOWEST_PASSING_GRADE per ``courserun_key`` from
@@ -27,7 +27,7 @@
   LPR_SNOWFLAKE_ROLE                         = None
   LPR_SNOWFLAKE_DATABASE                     = 'PROD'
   LPR_SNOWFLAKE_SCHEMA                       = 'ENTERPRISE'
-  LPR_SNOWFLAKE_INTERNAL_TABLE               = 'LEARNER_PROGRESS_REPORT_INTERNAL'
+  LPR_SNOWFLAKE_INTERNAL_TABLE               = 'LEARNER_PROGRESS_REPORT_EXTERNAL'
   LPR_COURSE_PROGRESS_CACHE_TIMEOUT          = 300    (5 min)
   LPR_SNOWFLAKE_LMS_DATABASE                 = 'PROD'
   LPR_SNOWFLAKE_LMS_SCHEMA                   = 'LMS'
@@ -180,7 +180,7 @@ class SnowflakeCourseProgressSource(SnowflakeLPRBaseSource):
     """
     Course progress data source backed by Snowflake.
 
-    Fetches COURSE_PROGRESS from ``LEARNER_PROGRESS_REPORT_INTERNAL`` filtered
+    Fetches COURSE_PROGRESS from ``LEARNER_PROGRESS_REPORT_EXTERNAL`` filtered
     by both ``enterprise_customer_uuid`` and the exact ``(user_email,
     courserun_key)`` pairs requested.  Results are cached per pair so that
     repeated page requests never re-query Snowflake for already-seen rows.
@@ -195,7 +195,7 @@ def _internal_table(cls):
         """Return the fully-qualified Snowflake table name for internal LPR data."""
         database = cls._get_setting('LPR_SNOWFLAKE_DATABASE', 'PROD')
         schema = cls._get_setting('LPR_SNOWFLAKE_SCHEMA', 'ENTERPRISE')
-        table = cls._get_setting('LPR_SNOWFLAKE_INTERNAL_TABLE', 'LEARNER_PROGRESS_REPORT_INTERNAL')
+        table = cls._get_setting('LPR_SNOWFLAKE_INTERNAL_TABLE', 'LEARNER_PROGRESS_REPORT_EXTERNAL')
         return f'{database}.{schema}.{table}'
 
     @classmethod
@@ -406,7 +406,7 @@ def _fetch_progress_for_pairs(self, enterprise_customer_uuid, pairs):
             if not rows:
                 LOGGER.warning(
                     '[course_progress] Snowflake returned 0 rows for enterprise=%s pairs=%d (batch %d). '
-                    'Verify LEARNER_PROGRESS_REPORT_INTERNAL contains data for this enterprise.',
+                    'Verify LEARNER_PROGRESS_REPORT_EXTERNAL contains data for this enterprise.',
                     enterprise_customer_uuid, len(batch), batch_start,
                 )
             else:

enterprise_data/tests/lpr/test_lpr_data_source_snowflake.py

@@ -2,18 +2,21 @@
 
 # pylint: disable=protected-access
 
+from types import SimpleNamespace
 from unittest.mock import MagicMock, patch
 
 import pytest
 
 from django.test import override_settings
 
+import enterprise_data.api.v1.views.lpr_data_source_snowflake as _lpr_module
 from enterprise_data.api.v1.views.lpr_data_source_snowflake import (
     DEFAULT_COURSE_PASSING_GRADE_CACHE_TIMEOUT,
     DEFAULT_COURSE_PASSING_GRADE_NEGATIVE_CACHE_TIMEOUT,
     DEFAULT_COURSE_PROGRESS_CACHE_TIMEOUT,
     SnowflakeCoursePassingGradeSource,
     SnowflakeCourseProgressSource,
+    _get_snowflake_connection,
 )
 from enterprise_data.cache import get_key
 
@@ -24,7 +27,7 @@
 ENTERPRISE_UUID = "a1b2c3d4-e5f6-7890-abcd-ef1234567890"
 NORMALIZED_UUID = "a1b2c3d4e5f67890abcdef1234567890"
 
-DEFAULT_TABLE = "PROD.ENTERPRISE.LEARNER_PROGRESS_REPORT_INTERNAL"
+DEFAULT_TABLE = "PROD.ENTERPRISE.LEARNER_PROGRESS_REPORT_EXTERNAL"
 DEFAULT_OVERVIEWS_TABLE = "PROD.LMS.COURSE_OVERVIEWS_COURSEOVERVIEW"
 
 
@@ -669,24 +672,21 @@ def cache_side_effect(cache_key):
 class TestGetSnowflakeConnection:
     """Tests for the module-level private-key connection factory."""
 
+    # _mock_connector is set in the autouse fixture (pytest fixture pattern).
+    # pylint: disable=attribute-defined-outside-init
+
     @pytest.fixture(autouse=True)
     def _patch_crypto_and_connector(self, monkeypatch):
         """Patch crypto libs and Snowflake connector so the real function can be called."""
-        from types import SimpleNamespace
-
-        import enterprise_data.api.v1.views.lpr_data_source_snowflake as mod
-
         self._mock_connector = MagicMock()
-        monkeypatch.setattr(
-            mod, "_snowflake", SimpleNamespace(connector=self._mock_connector)
-        )
+        monkeypatch.setattr(_lpr_module, "_snowflake", SimpleNamespace(connector=self._mock_connector))
 
         mock_key = MagicMock()
         mock_key.private_bytes.return_value = b"DER_BYTES"
         mock_ser = MagicMock()
         mock_ser.load_pem_private_key.return_value = mock_key
-        monkeypatch.setattr(mod, "_serialization", mock_ser)
-        monkeypatch.setattr(mod, "_default_backend", MagicMock(return_value="backend"))
+        monkeypatch.setattr(_lpr_module, "_serialization", mock_ser)
+        monkeypatch.setattr(_lpr_module, "_default_backend", MagicMock(return_value="backend"))
 
     @pytest.mark.parametrize(
         "overrides,missing_field",
@@ -698,10 +698,6 @@ def _patch_crypto_and_connector(self, monkeypatch):
     )
     def test_raises_on_missing_credentials(self, overrides, missing_field):
         """ValueError is raised when any required credential setting is absent."""
-        from django.test import override_settings
-
-        from enterprise_data.api.v1.views.lpr_data_source_snowflake import _get_snowflake_connection
-
         base = {
             "SNOWFLAKE_SERVICE_USER": "svc",
             "SNOWFLAKE_SERVICE_PRIVKEY": "pem",
@@ -714,13 +710,9 @@ def test_raises_on_missing_credentials(self, overrides, missing_field):
 
     def test_loads_pem_key_and_connects(self):
         """Happy path: loads PEM key, converts to DER, calls connector.connect."""
-        from django.test import override_settings
-
-        from enterprise_data.api.v1.views.lpr_data_source_snowflake import _get_snowflake_connection
-
         with override_settings(
             SNOWFLAKE_SERVICE_USER="svc_user",
-            SNOWFLAKE_SERVICE_PRIVKEY="-----BEGIN ENCRYPTED PRIVATE KEY-----\nfake\n-----END ENCRYPTED PRIVATE KEY-----",
+            SNOWFLAKE_SERVICE_PRIVKEY="-----BEGIN ENCRYPTED PRIVATE KEY-----\nfake",
             SNOWFLAKE_SERVICE_PASSPHRASE="s3cr3t",
             SNOWFLAKE_ACCOUNT="myaccount",
             SNOWFLAKE_ROLE="MY_ROLE",
@@ -735,10 +727,6 @@ def test_loads_pem_key_and_connects(self):
 
     def test_warehouse_passed_when_provided(self):
         """warehouse kwarg is forwarded to connector.connect when non-None."""
-        from django.test import override_settings
-
-        from enterprise_data.api.v1.views.lpr_data_source_snowflake import _get_snowflake_connection
-
         with override_settings(
             SNOWFLAKE_SERVICE_USER="u",
             SNOWFLAKE_SERVICE_PRIVKEY="pem",
@@ -750,10 +738,6 @@ def test_warehouse_passed_when_provided(self):
 
     def test_warehouse_omitted_when_none(self):
         """No ``warehouse`` key in connector.connect kwargs when warehouse=None."""
-        from django.test import override_settings
-
-        from enterprise_data.api.v1.views.lpr_data_source_snowflake import _get_snowflake_connection
-
         with override_settings(
             SNOWFLAKE_SERVICE_USER="u",
             SNOWFLAKE_SERVICE_PRIVKEY="pem",
@@ -765,10 +749,6 @@ def test_warehouse_omitted_when_none(self):
 
     def test_role_override_forwarded(self):
         """Explicit role kwarg overrides the settings default."""
-        from django.test import override_settings
-
-        from enterprise_data.api.v1.views.lpr_data_source_snowflake import _get_snowflake_connection
-
         with override_settings(
             SNOWFLAKE_SERVICE_USER="u",
             SNOWFLAKE_SERVICE_PRIVKEY="pem",