Skip to content

Add HTTP SUT files.#334

Open
Chounoki wants to merge 1 commit into
openconfig:mainfrom
Chounoki:pr2
Open

Add HTTP SUT files.#334
Chounoki wants to merge 1 commit into
openconfig:mainfrom
Chounoki:pr2

Conversation

@Chounoki

@Chounoki Chounoki commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new HTTP test service configuration under test/sut/http, including a Dockerfile, a Kubernetes deployment, a service, and a textproto configuration. The review feedback highlights three key issues: the Dockerfile references a non-existent Go version (1.26) which will cause build failures, the Kubernetes service defines a nodePort without setting the service type to NodePort, and the deployment container lacks resource requests and limits.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread test/sut/http/Dockerfile
Comment thread test/sut/http/service.yaml
Comment thread test/sut/http/deployment.yaml Outdated
@Chounoki Chounoki force-pushed the pr2 branch 9 times, most recently from 59d5359 to e8d1902 Compare June 9, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant